[Bug 21467] New: Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Bug ID: 21467 Summary: Allow several receipts for a given subscription Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea would be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17876 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79801&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79802&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |severine.queune@bulac.fr Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 [Bug 21474] Add the Koha::Subscription->frequency method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79801|0 |1 is obsolete| | Attachment #79802|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79834&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79835&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79836&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79837&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79838&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80546&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why "In Discussion"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #9)
Why "In Discussion"?
The patch is not ready for testing, I am iterating with the sponsor (Séverine @BULAC) by email. But you can read/test the patches and provide feedback if you want :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80546|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80706&action=edit Bug 21467: Fix default sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80707&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #13 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80717&action=edit Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79834|0 |1 is obsolete| | --- Comment #14 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80718&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79835|0 |1 is obsolete| | --- Comment #15 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80719&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79836|0 |1 is obsolete| | --- Comment #16 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80720&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79837|0 |1 is obsolete| | --- Comment #17 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80721&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79838|0 |1 is obsolete| | --- Comment #18 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80722&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80706|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80723&action=edit Bug 21467: Fix default sort Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80707|0 |1 is obsolete| | --- Comment #20 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80724&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588 [Bug 21588] Add "Collapse/Expand" options on subscription-detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply (on top of bug 21475: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21467: Allow several receipts for a given subscription Applying: Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Applying: Bug 21467: Add subscription's info when ordering Applying: Bug 21467: Do not erase the internal note of the first order Applying: Bug 21467: Display the quantity and adjust the amounts Applying: Bug 21467: Fix default sort Applying: Bug 21467: Display a summary line per parent_ordernumber error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21467: Display a summary line per parent_ordernumber The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21467-Display-a-summary-line-per-parentordernu-mjKFO_.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80718|0 |1 is obsolete| | Attachment #80719|0 |1 is obsolete| | Attachment #80720|0 |1 is obsolete| | Attachment #80721|0 |1 is obsolete| | Attachment #80722|0 |1 is obsolete| | Attachment #80723|0 |1 is obsolete| | Attachment #80724|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81394&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81395&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81396&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81397&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81398&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81399&action=edit Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81400&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In case you are faster than me: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt FAIL filters wrong_html_filter at line 79 ( <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid | html %]" title="Invoice detail page">) FAIL t/db_dependent/Acquisition.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't redeclare "my" in "my" t/db_dependent/Acquisition.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81430&action=edit Bug 21467: (QA follow-up) Fix filter and variable declaration in .t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, can you explain a bit more? 1) I am a little confused as to what items means in the test plan. Items from the order = Invoices I plan to enter? Or Issues? 2) What about the FIXMEs? - standing orders - why can't it cohabit? If these changes only applied to 'order by subscription' it would be ok, right? - cancelling order I'll come back to this, but continuing somewhere else first. Can you please check my follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #31)
Jonathan, can you explain a bit more?
1) I am a little confused as to what items means in the test plan. Items from the order = Invoices I plan to enter? Or Issues?
The number of issues you are expecting for this subscription.
2) What about the FIXMEs? - standing orders - why can't it cohabit? If these changes only applied to 'order by subscription' it would be ok, right?
You can create an order from a subscription, using a basket that has the standing orders flag.
- cancelling order
It was a question for the tester, and Séverine confirmed me it seems to work ok in case of cancelled orders.
I'll come back to this, but continuing somewhere else first.
Can you please check my follow-up?
It looks great, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 17876 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA tools are green, but there is a problem with the tests. I will continue testing, hoping for a quick follow-up: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Acquisition.t t/db_dependent/Acquisition.t .. 70/71 DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # No tests run! t/db_dependent/Acquisition.t .. 71/71 # Failed test 'No tests run for subtest "ModReceiveOrder and subscription"' # at t/db_dependent/Acquisition.t line 748. DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # Looks like your test exited with 255 just after 71. t/db_dependent/Acquisition.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/71 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 65280 Tests: 71 Failed: 1) Failed test: 71 Non-zero exit status: 255 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81797&action=edit Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81798&action=edit Bug 21467: (QA follow-up) Move hint a little bit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81799&action=edit Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA tool green, tests tool pass now. Acq tab in subscription detail works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81800&action=edit Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21475 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81394|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81801&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81395|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81802&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81396|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81803&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81397|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81804&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81398|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81805&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81399|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81806&action=edit Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81400|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81807&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81430|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81808&action=edit Bug 21467: (QA follow-up) Fix filter and variable declaration in .t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81797|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81809&action=edit Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81798|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81810&action=edit Bug 21467: (QA follow-up) Move hint a little bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81799|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81811&action=edit Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this is great in its flexibility and will work much better for acquisition of serials than the standing order feature. You will be able to handle an end-of-year invoice or being charged by issue. The amounts will be encumbered for the year. I think the only thing missing now would be an option to bring those orders into the next year, but the duplicate order line feature also waiting will help with that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82117&action=edit View of receipt page The language here is confusing in english, could: Quantity to receive be: Quantity outstanding or do you have another suggestion? the two receive/received is confusing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The terms haven't changed with these patches. Should we fix here or discuss a better wording in a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #54 from Andrew <andrew@bywatersolutions.com> --- Katrin makes a fair point about keeping this bug on-task and letting wording questions go elsewhere, but: I agree that receive/received gets confusing quickly in spoken English. "Outstanding" works but is not the most common usage. I'd go with "Quantity expected" or "Quantity ordered." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew from comment #54)
Katrin makes a fair point about keeping this bug on-task and letting wording questions go elsewhere, but: I agree that receive/received gets confusing quickly in spoken English. "Outstanding" works but is not the most common usage. I'd go with "Quantity expected" or "Quantity ordered."
I could write a follow-up. Maybe we could say Quantity delivered instead of expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21799 [Bug 21799] Change wording for quantity input fields on order receive page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81801|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82122&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81802|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82123&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81803|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82124&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81804|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82125&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81805|0 |1 is obsolete| | --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82126&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81806|0 |1 is obsolete| | --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82127&action=edit Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81807|0 |1 is obsolete| | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82128&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81808|0 |1 is obsolete| | --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82129&action=edit Bug 21467: (QA follow-up) Fix filter and variable declaration in .t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81809|0 |1 is obsolete| | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82130&action=edit Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81810|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82131&action=edit Bug 21467: (QA follow-up) Move hint a little bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81811|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82132&action=edit Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Rebased - number of tests and changes on the order receive form (added hints from Bug 21619) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Suggestion for template change on Bug 21799 - Change wording for quantity input fields on order receive page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #69 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Bug 21467 depends on bug 21474, which changed state. Bug 21474 Summary: Add the Koha::Subscription->frequency method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New Feature, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Allows the user to set a release notes| |quantity for a serial | |order, useful in the case | |where payments are made per | |receipt o findividual | |issues. This development | |also allows for altering | |the total expected quantity | |for a serial in the case of | |a periodicity change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Allows the user to set a |Allows the user to set a release notes|quantity for a serial |quantity for a serial |order, useful in the case |order, useful in the case |where payments are made per |where payments are made per |receipt o findividual |receipt to find individual |issues. This development |issues. This development |also allows for altering |also allows for altering |the total expected quantity |the total expected quantity |for a serial in the case of |for a serial in the case of |a periodicity change. |a periodicity change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Allows the user to set a |Allows the user to set a release notes|quantity for a serial |quantity for a serial |order, useful in the case |order, useful in the case |where payments are made per |where payments are made per |receipt to find individual |receipt of individual |issues. This development |issues. This development |also allows for altering |also allows for altering |the total expected quantity |the total expected quantity |for a serial in the case of |for a serial in the case of |a periodicity change. |a periodicity change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 [Bug 22239] JavaScript error on subscription detail page when there are no orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The pre-release notes for 19.05 show this bug report - maybe a follow-up pushed after release? https://gitlab.com/koha-community/koha-release-notes/blob/master/release_not... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Allows the user to set a |Appears as new feature in release notes|quantity for a serial |19.05 release notes, but is |order, useful in the case |18.11 - Remove from release |where payments are made per |notes before release |receipt of individual | |issues. This development |Allows the user to set a |also allows for altering |quantity for a serial |the total expected quantity |order, useful in the case |for a serial in the case of |where payments are made per |a periodicity change. |receipt of individual | |issues. This development | |also allows for altering | |the total expected quantity | |for a serial in the case of | |a periodicity change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 [Bug 24941] Serials: Link to basket in acqusition details is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org