https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42484 Bug ID: 42484 Summary: dead and misleading code remained in koha-es-indexer after 40890 Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com In koha-es-indexer, there is a default value for batch_size (around line 166) and an option to pass batch_size via the --batch_size parameter (around line 177). However, neither of these seems to have any effect since Bug 40890 introduced the line around 211: batch_size=$(get_es_indexer_batch_size ${name}) This appears to be dead code and should probably be removed, as it is misleading. Currently, the only effective default is set by get_es_indexer_batch_size in koha-functions.sh. By the way, the entry yazgfs/config/es_indexer_batch_size is missing from /etc/koha/sites/kohadev/koha-conf.xml on KTD. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.