[Bug 36270] New: Remove special handling for <<borrower-attribute:CODE>>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Bug ID: 36270 Summary: Remove special handling for <<borrower-attribute:CODE>> Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Borrower attributes should be simple enough to fetch using TT syntax now and the special casing here for the old template syntax is a blocker for it's removal. As this functionality is not documented anywhere and there's not any cases of it in use in the default shipped notices I think we should just remove it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Except.. the placeholder syntax is exposed in the selection options of the editor.. so it's likely in prevalent use all over the place :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162896&action=edit Bug 36270: Remove borrower-attribute:code from <<>> notices We need to replace this with a TT alternative however :| -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm reconsidering this given comment 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we provide a code example on how to achieve the same with TT? Or is this not available at all yet? I found a bug, but couldn't dig deeper yet: Bug 30657 - Make patron attributes available via Template Toolkit in overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- I can say that I've seen this used fairly often out in the wild. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 [Bug 30657] Make patron attributes available via Template Toolkit in overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30657 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 [Bug 30657] Make patron attributes available via Template Toolkit in overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do you have any clues on how often it's used with repeatable attributes Lucas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #6)
Do you have any clues on how often it's used with repeatable attributes Lucas?
Sorry Martin, I cannot really say with any certainty. I know I see it, but cannot say how widespread it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #8 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- <<borrower-attribute:code>> tag is used in our libraries for example in HOLD notices and HOLD_SLIP slips. We add patron's hold identifier and bookmobile stops to them with patron attributes. If this tag is removed we would need a substitute for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30657 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 [Bug 30657] Make patron attributes available via Template Toolkit in notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Bug 30657 gives you a replacement syntax for TT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- A database update could be implement a find and replace I guess -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org