[Bug 21404] New: Remove unused variables in C4::Breading->_auth_build_query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Bug ID: 21404 Summary: Remove unused variables in C4::Breading->_auth_build_query Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21318 Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21318 [Bug 21318] Add control number to authority Z39.50 search form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove unused variables in |Remove unused variables in |C4::Breading->_auth_build_q |C4::Breeding->_auth_build_q |uery |uery -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79357&action=edit Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79358&action=edit Bug 21404: Update test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79359&action=edit Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79357|0 |1 is obsolete| | Attachment #79358|0 |1 is obsolete| | Attachment #79359|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79443&action=edit Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79444&action=edit Bug 21404: Update test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79445&action=edit Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79443|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79492&action=edit Bug 21404: Remove unused variables in C4::Breeding->_auth_build_query Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79444|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79493&action=edit Bug 21404: Update test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79445|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79494&action=edit Bug 21404: Refactor _build_query subroutines Test plan: 1) Apply the patch 2) prove t/db_dependent/Breeding.t 3) Try to search using Z39.50, both, authority and biblio should still work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Bug 21404 depends on bug 21318, which changed state. Bug 21318 Summary: Add control number to authority Z39.50 search form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21318 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on bug 21318 not in 18.05.x, caused by bug 19436 not in 18.05.x. Marking as RESOLVED FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19436 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org