[Bug 29112] New: Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Bug ID: 29112 Summary: Module navigation sidebars in staff now show bullet points Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Not sure if this was an intentional change after all, but I noticed that on master the navigation sidebars (tools or administration for examples) now show bullet points before each link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In earlier versions instead of the standard bullet point a custom image with a small arrow was used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The image link appears now to be broken, but it's still in the code - so I guess this was not inentional after all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125746&action=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125746|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 125751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125751&action=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125751|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126013&action=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | CC| |joonas.kylmala@iki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Fixes the problem, passing QA but noting down that those global variables could be moved in the future to _vars.scss now that we have such a file. Not blocking this because of that because there was pre-existing global variables already in the _mixins.scss file. Also, please describe in the commit what the change does and not what problem it solves, at least not in the title. Makes easier to verify intended changes, otherwise I have to guess based on the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org