[Bug 22592] New: Elasticsearch - Support for index scan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Bug ID: 22592 Summary: Elasticsearch - Support for index scan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: ere.maijala@helsinki.fi Target Milestone: --- We can emulate index scan at least to some extent by using faceting with an include filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22413 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |ere.maijala@helsinki.fi |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 [Bug 22413] Elasticsearch - Index title is lost after sorting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Stefan Berndtsson <stefan.berndtsson@ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson@ub.gu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #1 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 87135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87135&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #2 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 87136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87136&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #3 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- I can't apply this patch. Do I need anything other than 22413 to make this work? It fails with: Applying: Bug 22592: Add index scan emulation to Elasticsearch error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22592: Add index scan emulation to Elasticsearch Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22592-Add-index-scan-emulation-to-Elasticsearc-iqm9C3.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87135|0 |1 is obsolete| | --- Comment #4 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 87344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87344&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87136|0 |1 is obsolete| | --- Comment #5 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 87345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87345&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #6 from Ere Maijala <ere.maijala@helsinki.fi> --- Stefan, thanks for testing. Nothing else is needed. I had to rebase, though, since there were changes in master. Just let bz follow the dependency and you should be good (for now...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Michal Denar <black23@gmail.com> --- Hi Ere, I'm not sure what but something make Elastic broken. I can!t reidex ES, U get: Can't locate object method "throw" via package "Koha::Exceptions::Elasticsearch::MARCFieldExprParseError" (perhaps you forgot to load "Koha::Exceptions::Elasticsearch::MARCFieldExprParseError"?) at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 794. I followed all dependencies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Michal Denar <black23@gmail.com> --- Hi Ere, I'm not sure what but something make Elastic broken. I can!t reidex ES, U get: Can't locate object method "throw" via package "Koha::Exceptions::Elasticsearch::MARCFieldExprParseError" (perhaps you forgot to load "Koha::Exceptions::Elasticsearch::MARCFieldExprParseError"?) at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 794. I followed all dependencies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #9 from Michal Denar <black23@gmail.com> --- Sorry, T was some problem with my kohadevbox. I set Need signet off back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87344|0 |1 is obsolete| | Attachment #87345|0 |1 is obsolete| | --- Comment #10 from Michal Denar <black23@gmail.com> --- Created attachment 87668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87668&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #11 from Michal Denar <black23@gmail.com> --- Created attachment 87669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87669&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14567 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patch does not apply Applying: Bug 22592: Add index scan emulation to Elasticsearch fatal: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22592: Add index scan emulation to Elasticsearch The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22592-Add-index-scan-emulation-to-Elasticsearc-ykcnua.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87668|0 |1 is obsolete| | --- Comment #13 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 88777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88777&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87669|0 |1 is obsolete| | --- Comment #14 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 88778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88778&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88777|0 |1 is obsolete| | Attachment #88778|0 |1 is obsolete| | --- Comment #15 from Michal Denar <black23@gmail.com> --- Created attachment 88807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88807&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #16 from Michal Denar <black23@gmail.com> --- Created attachment 88808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88808&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Alex Arnaud <alex.arnaud@biblibre.com> --- 1) This feature is MARC21 specific. Doesn't work with UNIMARC. 2) Typo in the POD for _build_scan_query and _create_regex_filter (missing underscores) 3) Missing tests for _aggregation_scan / search_compat 4) 4 tests added in QueryBuilder.t but subtest's plan test not updated. Tests fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88807|0 |1 is obsolete| | --- Comment #18 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 92391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92391&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88808|0 |1 is obsolete| | --- Comment #19 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 92392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92392&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #20 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 92393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92393&action=edit Bug 22592: Rebase, add UNIMARC support and fix tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |brendan@bywatersolutions.co | |m --- Comment #21 from Brendan Gallagher <brendan@bywatersolutions.com> --- I got to it too late - can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92391|0 |1 is obsolete| | Attachment #92392|0 |1 is obsolete| | Attachment #92393|0 |1 is obsolete| | --- Comment #22 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 93743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93743&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #23 from Ere Maijala <ere.maijala@helsinki.fi> --- Rebased and squashed the commits. In addition there is one change to search.pl to make it only consider the first idx parameter for the scan index to use. For some reason this check was commented out since the introduction of the code block in commit https://github.com/Koha-Community/Koha/commit/9f3e6b4a407ff79a5fa9ff627077de..., but without it the searches initiated from a scan field will use wrong search index. That's 11 years ago, which makes me wonder if something else broke it more recently, since otherwise it just means nobody is using the feature. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #24 from Séverine Queune <severine.queune@bulac.fr> --- Hi Ere, I've just tested with a sandbox and have an issue with the "Scan index" count, which is different of the total of results I get if I perform the search. I wondered about comment 17 made by Alex : is it supposed to work with Unimarc ? Is it the origin of my issue ? Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #25 from Ere Maijala <ere.maijala@helsinki.fi> --- The search it performs is currently not quite perfect match for the term list since search ignores punctuation etc. and may include results that start with the given term. Since the created search query does not carry information on the actual origin of the search, we can't handle it in a different way from a normal search in the ES code. I'm sure this could be further refined, but this is a minimal implementation to make not just fail completely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- So if my understanding is good, you mean I can sign the patch, am I right ? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #27 from Ere Maijala <ere.maijala@helsinki.fi> --- Yes, exactly! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #29 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93745&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #30 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Ere Maijala from comment #27)
Yes, exactly! :)
Thank you Ere ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93745|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94962&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel while this is not the 'perfect' scan search, it's a great first step forwards from not supporting it to giving pretty good results in most cases (better than with Zebra actually). I think we could even discuss for this to be a bug fix, as we offer the scan search with Elastic, but it didn't work before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872 [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34245 [Bug 34245] Scan index option only works on limited indexes -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org