http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14801&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Can you please clarify what "hide items from purchase suggestions forms" means? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I worded the title poorly. The idea is to limit the list of item types one can choose when making a purchase suggestion. Some libraries have some many item types that it would be overwhelming for a patron to choose the correct one from the list. The idea is to pare down the list to a more manageable size for the purpose of choosing an itemtype for a purchase suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Do we need to have the purchase suggestion form ask for the item type in the first place? Not all libraries use item types that double as material types -- for example, if your item types are 'NORMAL', 'SHORT', 'NO_LOAN', that's not going to be of much use to the patron. So here's my counter-proposal: since suggestions.itemtype is a varchar(30) anyway, why not give it text input widgets instead of a drop-down list of item types, and maybe relabel it to make it clear that the library is asking for the preferred format (e.g., print, ebook, video, etc.). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14801|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16647&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: 2 smalls remarks: 1/ FAIL C4/Koha.pm OK pod FAIL forbidden patterns forbidden pattern: tab char (line 201) forbidden pattern: tab char (line 199) forbidden pattern: tab char (line 200) forbidden pattern: tab char (line 193) forbidden pattern: tab char (line 194) I know there are a lot of tab around these lines... 2/ qq{} is badly used at 2 places. Prefer q{} if you don't need a variable interpolation. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16674|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19086&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: 1/ The syspref is created for OPAC but affect the intranet too : the C4::Koha::GetSupportList routine is used in suggestion/suggestion.pl. 2/ For the moment, this routine is only used in suggestions page, but could be used for something else, don't you think? 3/ Moreover it seems this routine is buggy. It does not deal with the multivalued AdvancedSearchTypes values (maybe I'm wrong). 4/ If the pref is equal to "ccode", don't we want to hide them too? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19086|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21759&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21760&action=edit Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA Followup -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21759|0 |1 is obsolete| | --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22714&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comments: Referring to Jonathan's comments and Kyle's replies: This works as advertised within its current limited implementation. Could be extended in the future. The function affects opac only now. Code looks good to me. No complaints from qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27932&action=edit Bug 9468: [COUNTER-PATCH] make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27934&action=edit Bug 9468: [COUNTER-PATCH] use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Galen Charlton <gmcharlt@gmail.com> --- I have attached a series of counter-patches. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37101&action=edit [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37103&action=edit [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #29)

Created attachment 37103 [details] [review] [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values To test ------- [1] Verify that the new SQL inserts added by this patch work.

Yes, it works, but only for English, please add them for others. The change to the opac prog theme should be removed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38164&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38166&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38168&action=edit Bug 9468: followup insert ignore -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, can you please take a look at Jonathan's comment#38? +use C4::Koha qw/GetSupportList/; I am not sure about some of the changes being intentional? if ($displayby =~ /status/i) { - if ( grep { /^($criteriumvalue)$/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { - return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))); - } else { - return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue) || $criteriumvalue; + unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { + return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; } + return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))) if ($displayby =~/status/i); } return (GetBranchName($criteriumvalue)) if ($displayby =~/branchcode/); - return (GetSupportName($criteriumvalue)) if ($displayby =~/itemtype/); + return GetAuthorisedValueByCode('SUGGEST_FORMAT', $criteriumvalue) || "Unknown" if ($displayby =~/itemtype/); Also, "Pending" looks untranslatable there. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41823&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41825&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41827&action=edit Bug 9468: followup insert ignore -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41937&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41939&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41941&action=edit Bug 9468: followup insert ignore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41943&action=edit Bug 9468: Fix syntax error in updatedb Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #56 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can u please rebase ASAP? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41936|0 |1 is obsolete| | Attachment #41937|0 |1 is obsolete| | Attachment #41938|0 |1 is obsolete| | Attachment #41939|0 |1 is obsolete| | Attachment #41940|0 |1 is obsolete| | Attachment #41941|0 |1 is obsolete| | Attachment #41942|0 |1 is obsolete| | Attachment #41943|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44504&action=edit Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove OPAC prog file Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44506&action=edit Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44508&action=edit Bug 9468 [QA Followup] Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44510&action=edit Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.