[Bug 12346] New: False patron modification alerts on members-home.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Bug ID: 12346 Summary: False patron modification alerts on members-home.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28621&action=edit Bug 12346 - False patron modification alerts on members-home.pl Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 1) Create a number of modification request for BranchA 2) Log into the staff intranet and set your branch to BranchB 3) Note the modifications alert to does display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Kyle, I am not seeing that behavior on master. Can you confirm the steps, and maybe include a quick video? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- I was able to reproduce your problem, but I got the following when I tried to use the members-home with the patch: Global symbol "$flags" requires explicit package name at /home/liz/koha-src/koha/members/members-home.pl line 97. Execution of /home/liz/koha-src/koha/members/members-home.pl aborted due to compilation errors. (Plus there was a minor conflict which seemed straightforward enough so I fixed that up, but still no luck.) Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Hm, actually let me give that one more go... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- I missed a thing in the merge issue - I got this to work so I'll have another look tomorrow - sorry about that. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I submitted modifications from patrons with several different home libraries (borrowers.branchcode) and logged in to the staff client using accounts from a couple of different libraries but I didn't see any difference in the count of pending patron modifications. It counted and displayed all pending modifications. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Still can't reproduce this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org