[Bug 8045] New: Problems on Due date when checking in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Priority: P2 Change sponsored?: --- Bug ID: 8045 CC: gmcharlt@gmail.com Assignee: adrien.saurat@biblibre.com Summary: Problems on Due date when checking in Severity: normal Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha When a document is checked in : 1) The due date displayed is the date of the checkin operation. It's not very useful for librarians as they can't see if the patron was late. 2) When checking in a late document, the displayed "due date" is not even the date of today, but the date of tomorrow! To correct both problems: -> Shouldn't we display the initial due date instead? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- CORRECTION: The bug only appears when the document is late, and the displayed date is then the date of tomorrow. Only one problem then. And no question about the solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 8046 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I suspect this commit: 99eccc18ed4a21fa416a3d61fed3f70825dc2203 (Bug 5549), but it's hard to tell because I can't even open returns.pl under that revision ("Undefined subroutine &main::now called at /home/oleonard/kohaclone/circ/returns.pl line 180.") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #4 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Looks like the problem comes from the _FixFineDaysOnReturn function in Circulation.pm The commit mentionned by Owen is pushed but the bug 5549 is still only signed off. Are the houly loans partly implemented ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- No the patch on there is a further enhancement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #6 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Ok. What I see is that after the following line : my $dt_due = dt_from_string( $datedue ); the $datedue value is broken, getting the value of today. Is dt_from_string really supposed to work this way? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #7 from Adrien SAURAT <adrien.saurat@biblibre.com> --- I misread some logs, the error actually comes from the following line in _FixFineDaysOnReturn: my $deltadays = $calendar->days_between( $dt_due, $dt_today ); When calculating the delay for the fine management, the due date is modified. I'm not familiar with these dates handling and I'm not sure yet of the best fix. I keep looking at it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 --- Comment #8 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 9428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9428&action=edit proposed patch #1 The due date was sent as a DateTime object parameter to the method "days_between" in Koha/Calendar.pm and was altered in the process. Added cloning to prevent this behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9428|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9429&action=edit [SIGNED-OFF] Bug 8045: fixes "date due" when checking in Added cloning of object parameters in "days_between" method. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Checked in items that were overdue, due in the future and not checked out and all showed the right info in the check in table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Clones start and end dates, which prevents any leaked modifications to the object. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Bugfix will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org