[Bug 32301] New: Show correct defaultSortField in Staff Client Advanced Search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Bug ID: 32301 Summary: Show correct defaultSortField in Staff Client Advanced Search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 144096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144096&action=edit Sort by option in Staff Client Advanced Search The defaultSortField system preference doesn't seem to affect the Staff Client Advanced Search, it still shows 'relevance' as the sort field whichever option you use in the syspref. However, when you submit the search it does in fact search by the value of the syspref. Need to: - In the advanced search in the staff client, display the correct default "sort by" option that is chosen in the defaultSortField system preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144096|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Sort by option in Staff Client Advanced Search The defaultSortField system preference doesn't seem to affect the Staff Client Advanced Search, it still shows 'relevance' as the sort field whichever option you use in the syspref. However, when you submit the search it does in fact search by the value of the syspref. Need to: - In the advanced search in the staff client, display the correct default "sort by" option that is chosen in the defaultSortField system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show correct |Show correct |defaultSortField in Staff |defaultSortField in staff |Client Advanced Search |client advanced search --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master. It works nicely in simple search, but not in advanced search: * Set defaultSortField: title * Set defaultSortOrder: A-Z * Do a catalog search for... anything (I used perl) * Sorting is alphabetic and in the sort pull down, the title has a little checkmark in front of the entry (could stand out a little more) * Set defaultSortField: author * Set defaultSortOrder: ascending * Searched for 'perl' again * No author is on top, rest seems to sort ok, C D G... * Checkmark on search shows But on advanced search, the search pull down seems stuck to Relevance no matter what. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Created attachment 144310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144310&action=edit Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search Sponsored-by: National Institute of Atmospheric and Water Research -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144310|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 144327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144327&action=edit Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search Sponsored-by: National Institute of Atmospheric and Water Research Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show correct |Show correct |defaultSortField in staff |defaultSortField in staff |client advanced search |interface advanced search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Wainui, I believe this fix is not completely right yet: 1) Do an advanced search, change the sort order from default to something else 2) In the result list click on "edit this search" on top of the results list 3) notice that the sort is kept 4) Apply patch, restart all the things 5) Repeat steps above - sort will be changed back to the default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Failed QA |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Katrin I've just re-tested this and believe it does work as described, can you please test again? Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to wainuiwitikapark from comment #3)
Created attachment 144310 [details] [review] Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search
Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search
To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search
Sponsored-by: National Institute of Atmospheric and Water Research
Works as described. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144327|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147984&action=edit Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search Sponsored-by: National Institute of Atmospheric and Water Research Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148326&action=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- I think Katrin is correct, I provided an alternate patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wainuiwitikapark@catalyst.n |nick@bywatersolutions.com |et.nz | Status|Signed Off |Needs Signoff CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148326|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148973&action=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148973|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149405&action=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick, this now also works with the "Edit search" as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Bug 32301 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This bug is present in 21.11.x, can it please be backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org