[Bug 13080] New: addClass('noEnterSubmit') no longer functioning for 5xx tags while cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Bug ID: 13080 Summary: addClass('noEnterSubmit') no longer functioning for 5xx tags while cataloging Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: costalc@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 32293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32293&action=edit noEnterSubmit Tested in koha-common 3.16.4. When trying to input text in a textarea html tag while cataloging the "intro" key does not funcion. Needs to fix file intranet-tmpl/prog/*LANG*/js/cataloging.js In LINE 486 erase 'noEnterSubmit' parameter in function addClass. So: - $(".input_marceditor, .indicator").addClass('noEnterSubmit'); + $(".input_marceditor, .indicator").addClass(''); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Cataloging |Templates Version|3.16 |master Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Summary|addClass('noEnterSubmit') |Addition of noEnterSubmit |no longer functioning for |class should not apply to |5xx tags while cataloging |textarea, only to input -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32363&action=edit Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, only to input The application of the "noEnterSubmit" class to textareas in the cataloging editor prevents the user from being able to use the Enter key to create line breaks. This is not intentional and should be corrected. This patch adds more specific scoping to the relevant JavaScript. To test, apply the patch and clear your browser cache if necessary. Open up the MARC editor and locate a tag which uses a textarea for entry. Try typing lines of text separated by line breaks. The enter key should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 --- Comment #2 from bondiurbano <costalc@gmail.com> --- (In reply to Owen Leonard from comment #1)
Created attachment 32363 [details] [review] Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, only to input
The application of the "noEnterSubmit" class to textareas in the cataloging editor prevents the user from being able to use the Enter key to create line breaks. This is not intentional and should be corrected.
This patch adds more specific scoping to the relevant JavaScript.
To test, apply the patch and clear your browser cache if necessary. Open up the MARC editor and locate a tag which uses a textarea for entry. Try typing lines of text separated by line breaks. The enter key should work correctly.
Tested and the enter key works correctly!! Great job! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from bondiurbano <costalc@gmail.com> --- Tested and the enter key works correctly!! Great job! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bondiurbano, thx for testing! - I have added a sing-off line for you on the patch. If you are using the sandboxes for testing they can do that for you too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32363|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32421&action=edit [PASSED QA] Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, only to input The application of the "noEnterSubmit" class to textareas in the cataloging editor prevents the user from being able to use the Enter key to create line breaks. This is not intentional and should be corrected. This patch adds more specific scoping to the relevant JavaScript. To test, apply the patch and clear your browser cache if necessary. Open up the MARC editor and locate a tag which uses a textarea for entry. Try typing lines of text separated by line breaks. The enter key should work correctly. Signed-off-by: bondiurbano costalc@gmail.com Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Can this be backported to 3.16.x ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11563 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org