[Bug 3908] New: Edit subscription page shows manual history block by default
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3908 Summary: Edit subscription page shows manual history block by default Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Serials AssignedTo: henridamien@koha-fr.org ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: --- When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. The template checks for the "history" variable: <!--TMPL_IF Name="history"--> $("#subscription_form_history").show();<!--/TMPL_IF--> And the script defines "history" according to the operation. Line 110: history => ($op eq 'mod'), I would think the "history" variable should be defined based on the status of the "manual history" checkbox when the subscription was created? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3908 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |oleonard@myacpl.org Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-01-21 15:17:47 --- Created an attachment (id=1473) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1473) Proposed fix Changing check for "history" variable to check for "manualhistory." -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3908 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3908 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com