https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97310&action=edit Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |tomascohen@gmail.com |ommunity.org | Status|Needs Signoff |ASSIGNED --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This seems to work ok. Assigning to Tomas for the next steps (ie. more work is needed if placerequest can be removed). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---

From Nick on bug 24571

""" In the staff client do a search that returns 20+ results that can be held Select all Place hold Confirm The api submits ~8 requests, then the page moves to the hold results, but not alll records are held While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback """ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #5)

From Nick on bug 24571

""" In the staff client do a search that returns 20+ results that can be held

Select all

Place hold

Confirm

The api submits ~8 requests, then the page moves to the hold results, but not alll records are held

While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback """

I'm thinking.. is there any RFC for bulk processing endpoints?.. maybe we can create an endpoint that does multiholds. What do You think Jonathan? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 24587 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98508|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98517&action=edit Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a simple partial revert to restore functionality.. Passing QA. Lets handle the final removal of those controllers and switch to REST apis as a separate issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 [Bug 24599] Add endpoints for bulk processing of holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.