[Bug 22896] New: [18.11] Item to be transferred at checkin clears overridden due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Bug ID: 22896 Summary: [18.11] Item to be transferred at checkin clears overridden due date Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- In backport of 21346 a few hidden inputs were lost in the conversion to modals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89667&action=edit Bug 22896: Missing inputs in transfer modal This patch restires hidden inputs to save overrideen checkin date in the checkin screen To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89667|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89670&action=edit Bug 22896: Missing inputs in transfer modal This patch restires hidden inputs to save overrideen checkin date in the checkin screen To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Attachment #89670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89671&action=edit Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89667|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89667|0 |1 is obsolete| | Attachment #89671|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89672&action=edit Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you explain a bit more what happened? I have compared the two commits and they are identical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Can you explain a bit more what happened? I have compared the two commits and they are identical.
Ah, it looks like I just got my code misaligned and hit the wrong conditions during testing, this is a master issue too. Ultimately these variables should probably all be in a block, but I think we need to fix quickly for now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[18.11] Item to be |Item to be transferred at |transferred at checkin |checkin clears overridden |clears overridden due date |due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89672|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89825&action=edit Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this is rather important to have before release... it all works as expected for me here so I'm going to PQA. Note: It might be nice to have a regression test for this (selenium), but I'm not of the opinion it's required at this stage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On second look, I think there's more to this.. there are a few more missing hidden form fields that got removed entirely in bug 21346 but still appear in returns.pl. I'm reverting my PQA until I've investigated further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22977 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22977 [Bug 22977] OMNIBUS: Ensure hidden fields are correctly passed during circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. PQA. We've moved my worry points to a followup bug report and will fix them early next cycle.. This patch fixes the issue reported and moves us forward. Go forth and push Mr RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.06 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 23062 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org