[Bug 24657] New: Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Bug ID: 24657 Summary: Fix tests of bug 22284 - Groups of pickup locations for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Tests in bug 22284 had conditions where they randomly fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22284 Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98883&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98883|0 |1 is obsolete| | --- Comment #2 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 98884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884 Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t Review of attachment 98884: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24657&attachment=98884) ----------------------------------------------------------------- ::: t/db_dependent/Koha/Item.t @@ +173,5 @@
+ my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } ); + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } ); + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } ); + my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } );
Do you really need to specify a branchcode here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I got another random failure, but not related to bug 22284. First time I see it I think. For the record: t/db_dependent/Holds.t ...... 1/61 # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 203. # got: undef # expected: '2304' t/db_dependent/Holds.t ...... 61/61 # Looks like you failed 1 test of 61. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98884|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98917&action=edit Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); To test: 1. do not apply this patch 2. in bash: for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done 3. Grab a cup of coffee (or tea if you are healthy) and wait for a while 4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit 5. Apply this patch 6. repeat step 2 and 3 (decaff this time!) 7. All 300 loops should pass 8. Sign off Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98918&action=edit Bug 24657: Do not explicitely pass a branchcode Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Agustin, good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #3)
Comment on attachment 98884 [details] [review] Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
Review of attachment 98884 [details] [review]: -----------------------------------------------------------------
::: t/db_dependent/Koha/Item.t @@ +173,5 @@
+ my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } ); + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } ); + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } ); + my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } );
Do you really need to specify a branchcode here?
Ups, that slipped away.. I used it to verify which libraries where tested, and when a library without one of those branchcodes appeared I realized that somewhere they where created. Thanks for the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests only and all look like sane and sensible changes to me. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |Test Suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26043 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
I got another random failure, but not related to bug 22284. First time I see it I think. For the record: t/db_dependent/Holds.t ...... 1/61 # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 203. # got: undef # expected: '2304' t/db_dependent/Holds.t ...... 61/61 # Looks like you failed 1 test of 61.
See bug 26043 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org