[Bug 19623] New: Move admin templates JavaScript to the footer: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Bug ID: 19623 Summary: Move admin templates JavaScript to the footer: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, nick@bywatersolutions.com, simon.pouchol@biblibre.com, testopia@bugs.koha-community.org Depends on: 19608 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some cataloging templates: addbooks.tt, linkitem.tt, merge.tt, z3950_auth_search.tt, z3950_search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move admin templates |Move template JavaScript to |JavaScript to the footer: |the footer: Cataloging |Cataloging | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69145&action=edit Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69145|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69163&action=edit Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With this patch applied, the Z39.50 search window remains empty. Owen, can you please check? Tested on kohadevbox with the sample data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70118&action=edit Bug 19623: (Follow-up) Correct footer include in pop-up windows This patch corrects the footer include in two templates for Z39.50 pop-up windows. popup-bottom.inc shouldn't be used because it doesn't have the JavaScript embed code in it. To test, perform a Z39.50 search from both the MARC bibliographic editor and the MARC authority editor. In both cases the Z39.50 popup window should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69163|0 |1 is obsolete| | Attachment #70118|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70144&action=edit Bug 19623 - Move template JavaScript to the footer: Cataloging This patch modifies some staff client cataloging templates so that JavaScript is included in the footer instead of the header. Several cataloging templates are excluded because they require significant structural changes: addbiblio.tt, additem.tt, and editor.tt To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Note that z350_auth_search.tt is tested by performing a Z39.50 search from the Authorities module. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70145&action=edit Bug 19623: (Follow-up) Correct footer include in pop-up windows This patch corrects the footer include in two templates for Z39.50 pop-up windows. popup-bottom.inc shouldn't be used because it doesn't have the JavaScript embed code in it. To test, perform a Z39.50 search from both the MARC bibliographic editor and the MARC authority editor. In both cases the Z39.50 popup window should work correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70146&action=edit Bug 19623: (QA follow-up) Add missing footerjs variable in merge.tt Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Bug 19623 depends on bug 19608, which changed state. Bug 19608 Summary: Move admin templates JavaScript to the footer: The rest https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25354 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org