https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 [Bug 20774] Trivial HTML error in itemslost.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75512&action=edit Bug 20807: Lost items report: Improve the display of CSV profile errors This patch modifies the template for the lost items report to change the way it handles a missing CSV profile. Now, if there is a missing CSV profile, a message is displayed with details about the profile requirements. If the logged-in user has the right permission there is a link to the CSV profiles page. Since item selection is used only in conjunction with exporting results, item selection controls are all hidden when there is no valid CSV profile. To test, apply the patch go to Reports -> Lost items. - Run the report with parameters which will return results. - If your system has no CSV profile for exporting lost items: - If you are logged in as a user with manage_csv_profiles permission: - You should see a message dialog instructing you to create a CSV profile with a link to the CSV profiles page. - If you are not logged in as a user with manage_csv_profiles permission: - You should see a similar message but without a link to the CSV profiles page. - In both cases, with no CSV profile defined there should be no checkboxes in the table of results and no "select all/clear all" controls. - If your system has a valid CSV profile for exporting lost items: - Checking the checkbox for one or more items in the table should trigger the display of an "Export selected items" link. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75512|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75513&action=edit Bug 20807: Lost items report: Improve the display of CSV profile errors This patch modifies the template for the lost items report to change the way it handles a missing CSV profile. Now, if there is a missing CSV profile, a message is displayed with details about the profile requirements. If the logged-in user has the right permission there is a link to the CSV profiles page. Since item selection is used only in conjunction with exporting results, item selection controls are all hidden when there is no valid CSV profile. To test, apply the patch go to Reports -> Lost items. - Run the report with parameters which will return results. - If your system has no CSV profile for exporting lost items: - If you are logged in as a user with manage_csv_profiles permission: - You should see a message dialog instructing you to create a CSV profile with a link to the CSV profiles page. - If you are not logged in as a user with manage_csv_profiles permission: - You should see a similar message but without a link to the CSV profiles page. - In both cases, with no CSV profile defined there should be no checkboxes in the table of results and no "select all/clear all" controls. - If your system has a valid CSV profile for exporting lost items: - Checking the checkbox for one or more items in the table should trigger the display of an "Export selected items" link. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75513|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75746&action=edit Bug 20807: Lost items report: Improve the display of CSV profile errors This patch modifies the template for the lost items report to change the way it handles a missing CSV profile. Now, if there is a missing CSV profile, a message is displayed with details about the profile requirements. If the logged-in user has the right permission there is a link to the CSV profiles page. Since item selection is used only in conjunction with exporting results, item selection controls are all hidden when there is no valid CSV profile. To test, apply the patch go to Reports -> Lost items. - Run the report with parameters which will return results. - If your system has no CSV profile for exporting lost items: - If you are logged in as a user with manage_csv_profiles permission: - You should see a message dialog instructing you to create a CSV profile with a link to the CSV profiles page. - If you are not logged in as a user with manage_csv_profiles permission: - You should see a similar message but without a link to the CSV profiles page. - In both cases, with no CSV profile defined there should be no checkboxes in the table of results and no "select all/clear all" controls. - If your system has a valid CSV profile for exporting lost items: - Checking the checkbox for one or more items in the table should trigger the display of an "Export selected items" link. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.