[Bug 29589] New: Translation issue with formatting in MARC overlay rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Bug ID: 29589 Summary: Translation issue with formatting in MARC overlay rules page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 14957 The message in the new MARC overlay rules page has bold formatting on the system preference names which breaks the string and leaves you with a single "the" to translate. But for languages like German "the" translates to different words depending on the 'gender' of the word. So we need to make sure that the word and the article appear together for translation: The MARCOverlayRules preference is not set, don't forget to enable it for rules to take effect. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128103&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29602 CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128103|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 128116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128116&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128116|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128698&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the fix! I didn't know about KohaSpan. I wonder if we could move this issue into coding guidelines somehow with some example on how to make formatting work without making it hard for translators. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Agreed, it should be part of the guidelines. Maybe we should wait for bug 29602, it contains several examples of what must be done (if we agree there). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Passed QA |Failed QA --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- QA tools returns : FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt FAIL filters missing_filter at line 59 ( The [% pref_MARCOverlayRules_link | $KohaSpan %] preference is not set, don't forget to enable it for rules to take effect.) I'm opening a new report for the usage of KohaSpan + filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29853 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not completely sure about my follow-up, but to explain: Adding a html filter, won't work, as the text in the span is actually HTML - a link in this case. so if you make it html | $KohaSpan it will just output the HTML and destroy the link (tested). Maybe we'd need something more flexible than KohaSpan - KohaTag? Having parameters that allow us to specify the html tag for the surrounding elements and href in addition to class and id. For now I am proposing $raw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128698|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131151&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131152&action=edit Bug 29589: (follow-up) Add TT filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This follow-up is a no-op, we shouldn't need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
This follow-up is a no-op, we shouldn't need it.
It would be just to silence the QA test tools. But you are right, it's no funtional change (are raw filters ever?) :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org