[Bug 29960] New: Remove Modernizr dependency in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Bug ID: 29960 Summary: Remove Modernizr dependency in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 10309 The OPAC has a little bit of JavaScript which depends on the browser's matchMedia API. At the time it was added, browsers didn't all support the API consistently. Modernizr was added to act as a polyfill to ensure compatibility. Browsers have caught up (https://caniuse.com/?search=matchmedia) so the Modernizr dependency can be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 [Bug 10309] New OPAC theme based on Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129892&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 [Bug 29603] Fix responsive behavior of facets menu in OPAC search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(... Applying: Bug 29960: Remove Modernizr dependency in the OPAC Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Falling back to patching base and 3-way merge... Removing koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js Removing koha-tmpl/opac-tmpl/bootstrap/js/script.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29960: Remove Modernizr dependency in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129892|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130216&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130216|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 130243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130243&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch refactors the release notes| |code around | |JavaScript-driven | |responsive behavior in the | |OPAC. The use of Modernizr | |removed as it is no longer | |needed. | | | |It also adds a | |missing entry for | |Enquire.js licensing on the | |About page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am having these in the QA test tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL valid_template Attempt to reload Koha/Template/Plugin/AdditionalContents.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
I am having these in the QA test tools:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206.
OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL valid_template Attempt to reload Koha/Template/Plugin/AdditionalContents.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206.
These appear unrelated to the patch, wondering if something is broken in master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am expecting sco print slip to be broken, 'enquire' won't be defined in global.js when included from sco/printslip.tt. But the print slip feature is broken in master right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30045 Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #7)
I am expecting sco print slip to be broken, 'enquire' won't be defined in global.js when included from sco/printslip.tt. But the print slip feature is broken in master right now.
Confirmed, "Uncaught ReferenceError: enquire is not defined". Tested on top of bug 30045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 [Bug 30045] SCO print slip is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130489&action=edit Bug 29960: (follow-up) Include enquire.js in print slip template This patch adds enquire.js to the print slip template in order to prevent a JS error. Also removed is a line from global.js which was added in the previous patch and which was an unwanted change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130243|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 130554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130554&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130489|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 130555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130555&action=edit Bug 29960: (follow-up) Include enquire.js in print slip template This patch adds enquire.js to the print slip template in order to prevent a JS error. Also removed is a line from global.js which was added in the previous patch and which was an unwanted change. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130554|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130576&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130555|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130577&action=edit Bug 29960: (follow-up) Include enquire.js in print slip template This patch adds enquire.js to the print slip template in order to prevent a JS error. Also removed is a line from global.js which was added in the previous patch and which was an unwanted change. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 [Bug 35638] Upgrade Enquire JS library from v2.0.1 to v2.1.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #13)
Created attachment 130577 [details] [review] Bug 29960: (follow-up) Include enquire.js in print slip template
This patch adds enquire.js to the print slip template in order to prevent a JS error.
Also removed is a line from global.js which was added in the previous patch and which was an unwanted change.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I am seeing this in the log when I am on sco/printslip.pl [WARN] File not found : lib/enquire.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36528 [Bug 36528] Incorrect path to enquire.js on self checkout slip print page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Bug 29960 depends on bug 30045, which changed state. Bug 30045 Summary: SCO print slip is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org