[Bug 31145] New: Add some defaults for acquisitions in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Bug ID: 31145 Summary: Add some defaults for acquisitions in TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues: 1 - The vendor website gets a random string - you can't edit the vendor without removing this 2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137653&action=edit Bug 31145: Supply defaults for vendors and funds This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues: 1 - The vendor website gets a random string - you can't edit the vendor without removing this 2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering To test: 1 - Apply patch 2 - Restart all 3 - Edit 'My vendor' 4 - note webstie is empty and you can save without changing anythign 5 - Add order to basket for my vendor 6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- 'reset_all' that is -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |jonathan.druart+koha@gmail. | |com, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137653|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137654&action=edit Bug 31145: Supply defaults for vendors and funds This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues: 1 - The vendor website gets a random string - you can't edit the vendor without removing this 2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering To test: 1 - Apply patch 2 - Restart all 3 - Edit 'My vendor' 4 - note webstie is empty and you can save without changing anythign 5 - Add order to basket for my vendor 6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- QA script happy. Simple change. Straight QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Not a big deal but this one seems weird to me. Why don't you pass the data you need instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
Not a big deal but this one seems weird to me. Why don't you pass the data you need instead?
TestBuilder is never going to put useful info here, seemed reasonable to default to NULL I don't need anything in these, but it did sometime interfere with testing or demo when fields had to be corrected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org