[Bug 16185] New: t/db_dependent/Reports_Guided.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Bug ID: 16185 Summary: t/db_dependent/Reports_Guided.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org "t_db_dependent_Reports_Guided_t.filter takes report id (661)" http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680/... prove t/db_dependent/Reports_Guided.t should run successfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Turns out my perlcritic happiness tendency found a solution. Scalar was being used as a function. Removing function-like bracketing fixed the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49784&action=edit Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49784|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49795&action=edit Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |minor CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org