https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |veron@veron.ch --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, I completely agree. I have asked when QAing bug 1983, and was not really convinced by the answer. But let it pass anyway. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47880&action=edit Bug 15681: Improve visibility of place hold option when checking out an item already checked out Have converted icons to font-awesome! To test: 1) Check out an item to a user 2) Attempt to check out the same item (ie same barcode) to another user 3) Confirm that message box says 'Please confirm checkout' with 3 newly styled buttons 4) Confirm 'cancel checkout and place a hold' button is styled the same as the other two buttons and clicking it takes you to page to place holds (reserves.pl) 5) Confirm behaviour of other two buttons works as expected also Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47891&action=edit Screenshot of a test case In testing this I randomly happened to pick an item which was both checked out and on hold for someone, so this dialog got pretty complicated. Currently buttons in dialogs have a special style which is different from other buttons. As you can see the patch doesn't modify them all. I would prefer to not use the Bootstrap style buttons here and keep the existing dialog button style. I think if we want to change the style of dialog buttons we should do it across the board. I'm beginning to do so--at least for the icons--with Bug 15785. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Aleisha Amohia from comment #4)

Ah I see! I think we should be changing all of the buttons and icons to be consistent with the buttons all over the site.

I see a value in having (slightly) different button styles for different areas, but this isn't a rule that anyone has discussed or agreed on. For instance: Toolbars get one button style, dialogs get another, everything else a third. This obviously isn't something we're being consistent about now because many new template changes are using Bootstrap-style buttons by default wherever they are. I'm interested in hearing your (and anyone else's) opinion about that idea. Koha really needs a style guide. More work, though, boo.

Should I make a patch for circ templates like you have for acquisitions and add it to your bug or just make a new bug for each module?

I think a new bug for each module makes sense so that it's easy to keep track of which patches depend on which. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Will fix this in patch for Bug 15821. -- You are receiving this mail because: You are watching all bug changes.