[Bug 15764] New: KOCT timestamp timezone problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Bug ID: 15764 Summary: KOCT timestamp timezone problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Web services Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org KOCT plugin send UTC timestamp, it should be converted to local timezone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 47791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47791&action=edit Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Had so much pain trying to get the KOCT to install and work in Firefox. Had to use Snap4evr, or something like that, to get the toolbar to be visible. And I don't know why it didn't log things right off the bat, but that was not a fun experience trying to get it to log. Now it does, but I can't seem to get it to send. I bet it is a protocol issue (https vs http). Also, you need to set that system preference too, right? Any configuration suggestions? Because this eyeballs fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is no configuration in Koha needed. Make sure that you close/open the plugin after entering the parameters. I have used it with Firefox ESR version a few days ago successfully with https://. The user used for uploading needs permissions and you have to enter your full. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47791|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47832&action=edit [SIGNED-OFF] Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha NOTE: I could not get "Commit to Koha" to work for me, but I did confirm this corrected behaviour with "Apply directly". Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I pity people who actually use this regularly, because unless someone has broken their skull open to actually get it to work, it is an awful piece of software. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #5)
I pity people who actually use this regularly, because unless someone has broken their skull open to actually get it to work, it is an awful piece of software.
The developers will appreciate. You can also open bug reports to help and improve it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I disagree with Mark - it's an easy to use tool and so far I haven't experienced problems with it. It might depend on browser version and we will probably have to change the plugin at some point as I think Mozilla seems to plan changes there. there (XUL?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #5)
I pity people who actually use this regularly, because unless someone has broken their skull open to actually get it to work, it is an awful piece of software.
This comment isn't helpful and is profoundly disrespectful to those who have spent time working on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 15748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47832|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47861&action=edit [SIGNED-OFF] Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha NOTE: I could not get "Commit to Koha" to work for me, but I did confirm this corrected behaviour with "Apply directly". Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Using the "commit to Koha" option works fine for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- PROBLEM! The desktop version does not do UTC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- I'd like to see an apology from Mark for his comment in comment 5. That was a totally unacceptable way to act Mark. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Chris Cormack from comment #12)
I'd like to see an apology from Mark for his comment in comment 5. That was a totally unacceptable way to act Mark.
True. I apologize. My frustration is mine alone, and does not reflect the great efforts of users and developers alike or the experiences of others. And this is not an appropriate place for such an outburst, nor is such an outburst acceptable behaviour. Again, I'm sorry everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to M. Tompsett from comment #13)
(In reply to Chris Cormack from comment #12)
I'd like to see an apology from Mark for his comment in comment 5. That was a totally unacceptable way to act Mark.
True. I apologize. My frustration is mine alone, and does not reflect the great efforts of users and developers alike or the experiences of others. And this is not an appropriate place for such an outburst, nor is such an outburst acceptable behaviour. Again, I'm sorry everyone.
Thank you Mark. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com --- Comment #15 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Katrin Fischer from comment #7)
It might depend on browser version and we will probably have to change the plugin at some point as I think Mozilla seems to plan changes there. there (XUL?).
^^^^^^^^ W.R.T xul perhaps we should keep the following in mind as the future of KOCT [1] http://arstechnica.com/information-technology/2015/08/mozilla-sets-plan-to-d... [2] https://blog.mozilla.org/addons/2015/08/21/the-future-of-developing-firefox-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to M. Tompsett from comment #11)
PROBLEM! The desktop version does not do UTC.
Which versions of Firefox and KOCT do you use ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I think Mark was worried about keeping compatibility with Kyle's desktop offline circ client (linked from circ module start page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Oh, I wasn't aware of the desktop client... Do you think we should change the desktop client to send UTC too ? Or change firefox plugin to send time in local timezone ? I would go for changing the desktop client as the timezones for client and server can differ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure what makes the most sense - timezones are confusing. Would there be an option to handle it inside of Koha like the patch does? Adding Kyle to this discussion for his opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #17)
Hi Julian, I think Mark was worried about keeping compatibility with Kyle's desktop offline circ client (linked from circ module start page).
Yes. However, after testing further, I see the routes of processing are not the same -- unless it is that pesky "Commit" route which I still can not for the life of me get working. My transactions disappear into nothingness. And this nothingness void exists for other methods too attempting anything except a direct application. I may end up screen casting these failures to see if someone sees something I am doing wrong or forgot to configure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #19)
I am not sure what makes the most sense - timezones are confusing.
Indeed. I was looking at the KOTC plugin source (I think it is the source), and noticing that it used CURRENT_TIMESTAMP. Clearly that timestamp's timezone differs from the desktop version. Thanks for the suggestion to read the manual. I figured out the three ways: https://addons.mozilla.org/en-US/firefox/search/?q=koct (Firefox plugin) https://github.com/bywatersolutions/koha-offline-circulation/releases (Desktop) "If the AllowOfflineCirculation preference is set to 'Enable'..." (http://translate.koha-community.org/manual/3.22/en/html-desktop/#offlinecirc) makes an HTML interface to offline available under Circulation in the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Julian Maurice from comment #18)
Oh, I wasn't aware of the desktop client...
See comment #21 for a link. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47861|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47982&action=edit Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha NOTE: I could not get "Commit to Koha" to work for me, but I did confirm this corrected behaviour with "Apply directly". Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Using the "commit to Koha" option works fine for me. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This patch only affects service.pl, which is not used in any way by the uploader for desktop client files. No changes to the desktop offline circ will be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #24 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8091 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org