[Bug 26683] New: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 Bug ID: 26683 Summary: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Both ./C4/Barcodes/ValueBuilder.pm and ./Koha/Z3950Responder/RPN.pm violate the Perl Critic policy of Modules::RequireFilenameMatchesPackage. You can read more about it at https://metacpan.org/pod/Perl::Critic::Policy::Modules::RequireFilenameMatch... The failures look like this: FAIL C4/Barcodes/ValueBuilder.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). FAIL Koha/Z3950Responder/RPN.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 111657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111657&action=edit Bug 26683: Decompose C4::Barcodes::ValueBuilder to make Perl critic happy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111657|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 111666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111666&action=edit Bug 26683: Decompose C4::Barcodes::ValueBuilder to make Perl critic happy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 111667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111667&action=edit Bug 26683: Decompose Koha::Z3950Responder::RPN into Net::Z3950::RPN::* packages This patch reverts the usage of Net::Z3950::SimpleServer's samples/render-search.pl example, and instead creates modified packages which will be loaded before the standard ones due to these being located higher up in the @INC path. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- C4::Barcodes::ValueBuilder test plan: 1. Iterate through the "autoBarcode" options 2. For each autoBarcode option, try generating a barcode at http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=29&searchid=scs_1602720764348 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 111669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111669&action=edit Bug 26683: Load localized Net::Z3950::RPN::* modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Koha::Z3950Responder::RPN test plan: 0. Open 2 terminals Terminal 1: 1. koha-z3950-responder --stop kohadev 2. perl misc/z3950_responder.pl Terminal 2: 3. yaz-client 127.0.0.1:2100/biblios 4. #Note connection accepted 5. find @or @1=4 Bruce @1=4 Damian 6. #Note Number of hits: 9 7. #Iterate through results using "show" and notice the 245 has either Bruce or Damian in it Note that this just makes sure the koha-z3950-responder is still running. It doesn't actually test that the Net::Z3950::RPN::* modules are actually doing anything it seems. Ere Maijala might be the best person to verify this, since he's the one who added Koha::Z3950Responder::RPN in Bug 13937 for "Add support for SRU and Elasticsearch" Before I added the 3rd patch "Load localized Net::Z3950::RPN::* modules", the t/db_dependent/Koha/Z3950Responder/GenericSession.t test was failing, but now it's passing. -- (It's a shame we don't have a "lib" directory that contains all our Perl modules, but that would require renaming too many files, so I don't see that ever happening...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26673 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #7 from David Cook <dcook@prosentient.com.au> --- I don't think this is needed thanks to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112814 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org