[Bug 14374] New: dont use mysql_auto_reconnect with BDIx::Connector
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Bug ID: 14374 Summary: dont use mysql_auto_reconnect with BDIx::Connector Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org BDIx::Connector doc indicates that handler option mysql_auto_reconnect must be false. See http://search.cpan.org/perldoc?DBIx%3A%3AConnector%3A%3ADriver%3A%3Amysql So it should not be setted in C4::Context -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 40062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40062&action=edit Bug 14374 - dont use mysql_auto_reconnect with BDIx::Connector BDIx::Connector doc indicates that handler option mysql_auto_reconnect must be false. See http://search.cpan.org/perldoc?DBIx%3A%3AConnector%3A%3ADriver%3A%3Amysql This patch removes this option setting in C4::Context Test plan : - Check connection to database does not fail for a long time page, such as a huge report -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14375 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|dont use |dont use |mysql_auto_reconnect with |mysql_auto_reconnect with |BDIx::Connector |DBIx::Connector CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Hi, (In reply to Fridolin SOMERS from comment #1)
Created attachment 40062 [details] [review] Bug 14374 - dont use mysql_auto_reconnect with BDIx::Connector
Curious new DBIx user questions: 1/ Shouldn't this bug be dependent on bug #14375 ? 2/ Unless it is dependent on ^^^, would it not be better to set it to "0" instead of removing it? <quote>Note that if you are using a module or framework that performs reconnections for you (for example DBIx::Connector in fixup mode), this value must be set to 0.</quote> - http://search.cpan.org/~capttofu/DBD-mysql-4.031/lib/DBD/mysql.pm thanks -indranil -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14600 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Shouldn't this bug be merged into Bug 14375? You cannot disable - $dbh->{mysql_auto_reconnect} = 1; Without first introducing the DBIx::Connector? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #3)
Shouldn't this bug be merged into Bug 14375? You cannot disable - $dbh->{mysql_auto_reconnect} = 1; Without first introducing the DBIx::Connector?
Bug 14375 does not introduce the use of DBIx::Connector, it's Bug 13645 pushed since 3.16. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13645 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 [Bug 13645] DBIx connection needs to be cached -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14778 Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- DBIx::Connector is now gone, see bug 14778. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org