[Bug 25896] New: Missing closing </td> tag in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Bug ID: 25896 Summary: Missing closing </td> tag in smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: slavashishkin@gmail.com Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, julian.maurice@biblibre.com, martin.renvoize@ptfs-europe.com, stalkernoid@gmail.com Depends on: 21395 File: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt with adding of "daysmode" block just have one lost closing </td> tag: <td> [% SWITCH daysmode %] ... <td> all other <td> tags we have there are closed, yet modern browsers even "fixes" this on the fly so nothing to check visually or to spot any changes, so fix is even have no "browser" test procedure: just go wget/curl and compare generated htmls :)... heh :). Longer describe than fix :) Slava, please just post a quick fix commit. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 [Bug 21395] Make perlcritic happy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 106420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106420&action=edit Bug 25896: Add missing closing </td> tag File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had one lost closing </td> tag in "daysmode" block. Added. Mentored-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21395 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 [Bug 21395] Make perlcritic happy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|julian.maurice@biblibre.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106420|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106455&action=edit Bug 25896: Add missing closing </td> tag File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had one lost closing </td> tag in "daysmode" block. Added. Mentored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106455|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106471&action=edit Bug 25896: Add missing closing </td> tag File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had one lost closing </td> tag in "daysmode" block. Added. Mentored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- missing a dependency for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing closing </td> tag |Missing closing `td` tag in |in smart-rules.tt |smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org