[Bug 8629] New: update of statistics fields on fund selection in order creation/edition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Priority: P5 - low Change sponsored?: --- Bug ID: 8629 Assignee: koha-bugs@lists.koha-community.org Summary: update of statistics fields on fund selection in order creation/edition Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha In 'neworderempty' and 'addorederis2709', changing fund will call the ajax function 'fetchSortDropbox' (acq.js). If fund selected has a defined authorized value for statistic field 'sort1', a combo-box is displayed for this field (idem for sort2). Bug is that when switching from a found with authorized value to one without authorized value, statistic field is an empty combo-box instead of a free text input. Also, permission on fetch_sort_dropbox.pl was 'edit_catalogue'. I set it to 'order_manage', the same has 'neworderempty.pl' and 'addorederis2709.pl'. I added a behavior : when statistic field is already a free text input and fund selected is without authorized value, the field is not modified to preserve its value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11575&action=edit Proposed patch Proposed patch. Now fetchSortDropbox() replaces entire existing statistic field (select or input) by a select or an input. So fetch_sort_dropbox.pl returns an entire select or input. Test plan : ----------- Create a fund with authorized values for statistics : "foundwith". Create a fund without authorized values for statistics : "foundwithout". In a acquisition basket : For both order creation/edition : "from a new (empty) record" and "from a staged file" : Create a new order. => statistic fields will be free text boxes. Select "foundwith" fund. => statistic fields turns to combo-boxes. Select "foundwithout" fund. => statistic fields turns to free text boxes. Enter a value in statistic fields. Save the order. Modify it. => the statistic values are well saved. Select "foundwith" fund. Select values for statistic fields. Save the order. Modify it. => the statistic values are well saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11575|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 11602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11602&action=edit [SIGNED-OFF] Bug 8629: update of statistics fields on fund selection in order creation/edition Signed-off-by: Marc Veron <veron@veron.ch> Followed test plan in comment #1 Behaves as described in the test plan. Useful feature! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 11602 [details] [SIGNED-OFF] Bug 8629: update of statistics fields on fund selection in order creation/edition
Signed-off-by: Marc Veron <veron@veron.ch>
Followed test plan in comment #1 Behaves as described in the test plan. Useful feature!
patch looks good, passing QA... $ koha-qa.pl -c testing 1 commit(s) (applied to commit 60790d0) * 2ffc88c Bug 8629: update of statistics fields on fund selection in order acqui/addorderiso2709.pl acqui/fetch_sort_dropbox.pl acqui/neworderempty.pl koha-tmpl/intranet-tmpl/prog/en/js/acq.js koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt * acqui/addorderiso2709.pl OK * acqui/fetch_sort_dropbox.pl OK * acqui/neworderempty.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org