[Bug 34497] New: Vue - Dialog component should allow for confirmation input options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Bug ID: 34497 Summary: Vue - Dialog component should allow for confirmation input options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: pedro.amorim@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154319&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|jonathan.druart+koha@gmail. |pedro.amorim@ptfs-europe.co |com |m --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Currently missing cypress tests for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pedro Amorim from comment #2)
Currently missing cypress tests for this.
Cypress tests will come in the ERM sushi submission, where the code that makes use of this exists. Coming up with a test patch for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154329&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154319|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154332&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154329|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154333&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154332|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157519&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154333|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157520&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good to me.. adding my signoff to keep it moving along. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157519|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157521&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157520|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157522&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- "required" does not work. - input => input.required && input.value == null + input => input.required && input.value == "" Works for input, but still not working for dates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157527&action=edit Bug 34497: Fix required text field input.value can be either null (if flatpickr date field empty) or '' (if simple text input empty), so check for !input.value instead to account for both situations. Add missing 'required' attribute to text inputs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157527|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157530&action=edit Bug 34497: (QA follow-up):Fix required text field input.value can be either null (if flatpickr date field empty) or '' (if simple text input empty), so account for both situations. Add missing 'required' attribute to text inputs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157521|0 |1 is obsolete| | Attachment #157530|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 157531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157531&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 157532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157532&action=edit Bug 34497: (QA follow-up):Fix required text field input.value can be either null (if flatpickr date field empty) or '' (if simple text input empty), so account for both situations. Add missing 'required' attribute to text inputs. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35120 [Bug 35120] ERM - We need tests for Dialog inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org