[Bug 32450] New: Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Bug ID: 32450 Summary: Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: michaela.sieber@kit.edu We do have several permissions that are about what is counted for noissuecharge, the dynamic restriction for circulation. * ManInvInNoissuesCharge = All manual invoiceable debit types * RentalsInNoissuesCharge = Exclude hold charges * HoldsInNoissuesCharge = Exclude rental charges This all comes from a time when Koha's debit types were hardcoded, but had no 'home' in the database. Now that they have their own database table we could move them to a flag for each debit type. This was triggered by a discussion by making a certain debit type not count towards the circulation restriction, but our current system is to inflexible in that regard. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've had a look at our current code and it looks the proposed solution is already part of a FIXME: sub non_issues_charges { my ($self) = @_; #NOTE: With bug 23049 these preferences could be moved to being attached #to individual debit types to give more flexability and specificity. my @not_fines; push @not_fines, 'RESERVE' unless C4::Context->preference('HoldsInNoissuesCharge'); push @not_fines, ( 'RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW' ) unless C4::Context->preference('RentalsInNoissuesCharge'); unless ( C4::Context->preference('ManInvInNoissuesCharge') ) { my @man_inv = Koha::Account::DebitTypes->search({ is_system => 0 })->get_column('code'); push @not_fines, @man_inv; } But looking at the code I also realized another thing * ManInvInNoissuesCharge = All manually invoiceable debit types This is wrong, it's not only the manually invoiceable ones per the checkbox you can set, but all manually added debit types, which makes this even less flexible than we had initially thought. * ManInvInNoissuesCharge = All manually added debit types, all but the system internal ones -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145080&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subrout ine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145081&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows a release notes| |user to select which debit | |types should be included in | |deciding whether a patron | |should be restricted from | |checkouts (noissuescharge | |system preference). Three | |existing system preferences | |have been deleted | |(ManInvInNoissuesCharge, | |RentalsInNoissuesCharge, | |HoldsInNoissuesCharge) and | |the management of the debit | |types now sits in the Debit | |Types area of system | |preferences. The user can | |edit each debit type and | |select whether it should be | |included in the | |noissuescharge calculation, | |giving users much more | |flexibility over | |restrictions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145080|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145127&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subrout ine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145081|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145128&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 145127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145127 Bug 32450: Noissuescharge debit type exclusions Review of attachment 145127: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32450&attachment=145127) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +711,5 @@
my ($self) = @_;
+ my @fines; + my $dbh=C4::Context->dbh; + my $sth = $dbh->prepare("SELECT code FROM account_debit_types WHERE no_issues_charge = 1");
Sorry Matt, this will need to be converted to a DBIC style lookup rather than using a handle.. we dis-sallow direct SQL in the Koha:: namespace. https://metacpan.org/pod/DBIx::Class::ResultSet#search is a good starting place for how this works.. especially the WHERE clause link from it. tl:dr; It'll be something along the lines my $blocking_types => Koha::Debit::Types->search({ no_issues_charge => 1 }, { columns => 'code' }); Then the ->lines->search could use it inline. $self->lines->search( { debit_type_code => { '-in' => $blocking_types } } ); This so pseudo code untested ;P ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt @@ +220,2 @@
<td class="actions"> + [% IF !debit_type.archived %]
Hmm, I wonder if at least some of the fields in system level types need to be marked as read only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 145128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145128 Bug 32450: Update db to add noissuescharge flag and remove sysprefs Review of attachment 145128: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32450&attachment=145128) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl @@ +6,5 @@
+ up => sub { + my ($args) = @_; + my ($dbh, $out) = @$args{qw(dbh out)}; + + if( !column_exists( 'account_debit_types', 'no_issues_charge' ) ) {
I'd be tempted to name this 'blocks_issue' or 'prevents_issue' or something as opposed to 'no_issues_charge'. @@ +15,5 @@
+ say $out "Added column 'account_debit_types.no_issues_charge'"; + } + + $dbh->do(q{ + DELETE FROM systempreferences WHERE variable = 'ManInvInNoissuesCharge'
We'll need an extra step in here I'm afraid.. We're not accounting for the current state of the system preference at upgrade time. You'll want to check the current value of ManInvInNoissuesCharge and set the boolean flag for the appropriate, prior to this patch hard coded, set of debit types based on it. @@ +19,5 @@
+ DELETE FROM systempreferences WHERE variable = 'ManInvInNoissuesCharge' + }); + + $dbh->do(q{ + DELETE FROM systempreferences WHERE variable = 'RentalsInNoissuesCharge'
As above @@ +22,5 @@
+ $dbh->do(q{ + DELETE FROM systempreferences WHERE variable = 'RentalsInNoissuesCharge' + }); + $dbh->do(q{ + DELETE FROM systempreferences WHERE variable = 'HoldsInNoissuesCharge'
As above -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145128|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145171&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145127|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145172&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subrout ine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145171|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145189&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145190&action=edit Bug 32450: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145172|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145191&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subroutine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I restored the signoff lines and split the dbic build out of the first patch.. it's customary to commit that one separately as it's the most likely one to clash on rebases. Code is looking good now, but I think we need the Unit tests updating.. Calls to 'non_issues_charges' appear to be present in db_dependent/Accounts.t and db_dependent/Koha/Patron.t. It's worth running them, and perhaps the other accounts related tests in ktd to see if they still pass Matt.. and maybe worth looking to check that your change is now covered in those tests too ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145194&action=edit Bug 32450: Unit tests updated Unit tests for the non_issues_charges function have been updated to remove the system preferences and test based on the new database flags Test plan: 1) Apply all patches 2) In the kshell, run prove -v t/db_dependent/Accounts.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145198&action=edit Bug 32450: Add boolean to DBIC schema Adding boolean flag to DBIC schema. Test plan as per previous commits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl FAIL file permissions File must have the exec flag FAIL t/db_dependent/Accounts.t FAIL valid "my" variable $total masks earlier declaration in same scope "my" variable $non_issues_charges masks earlier declaration in same scope "my" variable $other_charges masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- __PACKAGE__->add_columns( '+is_system' => { is_boolean => 1 } ); __PACKAGE__->add_columns( "+can_be_sold" => { is_boolean => 1 } ); __PACKAGE__->add_columns( "+can_be_invoiced" => { is_boolean => 1 } ); __PACKAGE__->add_columns( "+restricts_checkouts" => { is_boolean => 1 } ); Can you merge those in one statement btw ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147563&action=edit Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145189|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149653&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145190|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149654&action=edit Bug 32450: DBIC Schema Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145191|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149655&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subroutine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145194|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149656&action=edit Bug 32450: Unit tests updated Unit tests for the non_issues_charges function have been updated to remove the system preferences and test based on the new database flags Test plan: 1) Apply all patches 2) In the kshell, run prove -v t/db_dependent/Accounts.t 3) All tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145198|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149657&action=edit Bug 32450: Add boolean to DBIC schema Adding boolean flag to DBIC schema. Test plan as per previous commits Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147563|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149658&action=edit Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149659&action=edit Bug 32450: (QA follow-up) Polishing atomic update Database comment. Variable names. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149660&action=edit Bug 32450: (QA follow-up) Update UsageStats for removed prefs Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This looks quite good. But still needs some attention. I didnt finish up yet, but will post some findings already. Please give attention first to the failing tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- TODO Fix t/db_dependent/SIP/Patron.t # Subtest: NoIssuesChargeGuarantees tests 1..6 not ok 1 - Only patron's fines are reported in total # Failed test 'Only patron's fines are reported in total' # at t/db_dependent/SIP/Patron.t line 315. # got: '0' # expected: '11' not ok 2 - Guarantor blocked # Failed test 'Guarantor blocked' # at t/db_dependent/SIP/Patron.t line 316. not ok 3 - Screen message includes related fines total # Failed test 'Screen message includes related fines total' # at t/db_dependent/SIP/Patron.t line 317. # 'Greetings from Koha. yauSBUttb' # doesn't match '(?^u:Patron blocked by fines \(11\.11\) on guaranteed accounts)' ok 4 - Guarantee only fines correctly counted ok 5 - Guarantee not blocked by guarantor fines ok 6 - Screen message does not include blocked message # Looks like you failed 3 tests of 6. not ok 9 - NoIssuesChargeGuarantees tests # Failed test 'NoIssuesChargeGuarantees tests' # at t/db_dependent/SIP/Patron.t line 326. TODO t/db_dependent/SIP/Transaction.t # Looks like you failed 3 tests of 17. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Preliminary QA Comments Bit confusing as to naming. + my @renewals = ('RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW'); + if($_ eq 'RentalsInNoissuesCharge') { push @debit_types_to_update, @renewals}; Will fix in a follow-up. + if($_ eq 'ManInvInNoissuesCharge') { push @debit_types_to_update, @manual}; Perl allows you to do: statement if condition; for these kind of lines. When we are using { }, we normally add newlines etc. No blocker This is a theory thing. But if you run it multiple times, the field has been inserted already and the DEFAULT 1 has been applied. The sysprefs have been deleted, so saying 'default value has been applied' is not true anymore. They are not reset again or so. No blocker, just noting. Wording is a bit less intuitive. The column name is No issues charge (which is already obscure). And then we could have the value Not included. Twice, no and not, might not be very clear. No blocker, could be improved. Or even should be, I am breaking my head every time ;) Similar for sub non_issues_charges. Already existed. But non should better be no here, I guess. Leaving as-is. Remove prefs from C4/UsageStats.pm. See follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149858&action=edit Bug 32450: (QA follow-up) Fix failing tests This patch fixes the failing tests in t/db_dependent/SIP/Patron.t Test plan: Run prove -v t/db_dependent/SIP/Patron.t and all tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #32 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149859&action=edit Bug 32450: (QA follow-up) Change wording in debit types table This patch changes confusing wording in the debit types table. Column heading No issues charge has been changed to Blocks checkouts? and the column data is now simply Yes/No rather than Included/Not included Test plan: 1) Apply patch 2) Navigate to debit types in administration 3) The column in the table should exist as described above -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks Matt. Revisiting this one now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- prove Circulation.t Circulation/NoIssuesChargeGuarantees.t Circulation/Returns.t Circulation/_CalculateAndUpdateFine.t Circulation/issue.t Koha/Account.t Koha/Account/Line.t Koha/Account/Lines.t Koha/Account/Offsets.t Koha/Cash/Register.t Koha/Cash/Register/Cashup.t Koha/Charges/Sales.t Koha/Checkouts.t Koha/Items.t Koha/Patron.t Koha/Plugins/Account_hooks.t Letters/TemplateToolkit.t Members.t Overdues.t Reserves.t SIP/Patron.t api/v1/patrons_accounts.t Circulation.t ........................... 62/66 Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Circulation.t ........................... ok Circulation/NoIssuesChargeGuarantees.t .. ok Circulation/Returns.t ................... ok Circulation/_CalculateAndUpdateFine.t ... ok Circulation/issue.t ..................... ok Koha/Account.t .......................... ok Koha/Account/Line.t ..................... ok Koha/Account/Lines.t .................... ok Koha/Account/Offsets.t .................. ok Koha/Cash/Register.t .................... ok Koha/Cash/Register/Cashup.t ............. ok Koha/Charges/Sales.t .................... ok Koha/Checkouts.t ........................ ok Koha/Items.t ............................ ok Koha/Patron.t ........................... ok Koha/Plugins/Account_hooks.t ............ ok Letters/TemplateToolkit.t ............... ok Members.t ............................... ok Overdues.t .............................. ok Reserves.t .............................. 8/77 No reserves HOLD_CANCELLATION letter transported by email at /usr/share/koha/C4/Letters.pm line 588. Reserves.t .............................. ok SIP/Patron.t ............................ ok api/v1/patrons_accounts.t ............... ok All tests successful. Files=22, Tests=422, 216 wallclock secs ( 0.85 usr 0.12 sys + 167.92 cusr 25.45 csys = 194.34 CPU) Result: PASS Looks promising :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep -l Accountline Accounts.t ILSDI_Services.t Koha/Cash/Register.t Koha/Patrons.t Patrons.t SIP/Patron.t SIP/Transaction.t api/v1/patrons_accounts.t They pass too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Matt Blenkinsop from comment #32)
Created attachment 149859 [details] [review] Bug 32450: (QA follow-up) Change wording in debit types table
This patch changes confusing wording in the debit types table. Column heading No issues charge has been changed to Blocks checkouts? and the column data is now simply Yes/No rather than Included/Not included
Yes, I think that is clearer indeed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149653|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149872&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149654|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149873&action=edit Bug 32450: DBIC Schema Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149655|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149874&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subroutine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149656|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149875&action=edit Bug 32450: Unit tests updated Unit tests for the non_issues_charges function have been updated to remove the system preferences and test based on the new database flags Test plan: 1) Apply all patches 2) In the kshell, run prove -v t/db_dependent/Accounts.t 3) All tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149657|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149876&action=edit Bug 32450: Add boolean to DBIC schema Adding boolean flag to DBIC schema. Test plan as per previous commits Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149658|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149877&action=edit Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149659|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149878&action=edit Bug 32450: (QA follow-up) Polishing atomic update Database comment. Variable names. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149660|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149879&action=edit Bug 32450: (QA follow-up) Update UsageStats for removed prefs Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149858|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149880&action=edit Bug 32450: (QA follow-up) Fix failing tests This patch fixes the failing tests in t/db_dependent/SIP/Patron.t Test plan: Run prove -v t/db_dependent/SIP/Patron.t and all tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149859|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149881&action=edit Bug 32450: (QA follow-up) Change wording in debit types table This patch changes confusing wording in the debit types table. Column heading No issues charge has been changed to Blocks checkouts? and the column data is now simply Yes/No rather than Included/Not included Test plan: 1) Apply patch 2) Navigate to debit types in administration 3) The column in the table should exist as described above Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149882&action=edit Bug 32450: (QA follow-up) Fix SIP/Transaction.t You forgot this one, Matt. Comment29 :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome guys, thanks for this.. great to see it worked through and the teamwork that happened here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also very glad to see this has reached PQA, thanks to all involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows a |**Sponsored by** *PTFS release notes|user to select which debit |Europe* |types should be included in | |deciding whether a patron |This enhancement |should be restricted from |allows a user to select |checkouts (noissuescharge |which debit types should be |system preference). Three |included in deciding |existing system preferences |whether a patron should be |have been deleted |restricted from checkouts |(ManInvInNoissuesCharge, |(noissuescharge system |RentalsInNoissuesCharge, |preference). Three existing |HoldsInNoissuesCharge) and |system preferences have |the management of the debit |been deleted |types now sits in the Debit |(ManInvInNoissuesCharge, |Types area of system |RentalsInNoissuesCharge, |preferences. The user can |HoldsInNoissuesCharge) and |edit each debit type and |the management of the debit |select whether it should be |types now sits in the Debit |included in the |Types area of system |noissuescharge calculation, |preferences. The user can |giving users much more |edit each debit type and |flexibility over |select whether it should be |restrictions. |included in the | |noissuescharge calculation, | |giving users much more | |flexibility over | |restrictions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | |This enhancement |This enhancement |allows a user to select |allows a user to select |which debit types should be |which debit types should be |included in deciding |included in deciding |whether a patron should be |whether a patron should be |restricted from checkouts |restricted from checkouts |(noissuescharge system |(`noissuescharge` system |preference). Three existing |preference). Three existing |system preferences have |system preferences have |been deleted |been deleted |(ManInvInNoissuesCharge, |(`ManInvInNoissuesCharge`, |RentalsInNoissuesCharge, |`RentalsInNoissuesCharge`, |HoldsInNoissuesCharge) and |`HoldsInNoissuesCharge`) |the management of the debit |and the management of the |types now sits in the Debit |debit types now sits in the |Types area of system |Debit Types area of system |preferences. The user can |preferences. The user can |edit each debit type and |edit each debit type and |select whether it should be |select whether it should be |included in the |included in the |noissuescharge calculation, |`noissuescharge` |giving users much more |calculation, giving users |flexibility over |much more flexibility over |restrictions. |restrictions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 [Bug 33787] Remove option to archive system debit types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org