[Bug 5749] New: The display of borrower adresses composed of streetnumber, streettype and address is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Summary: The display of borrower adresses composed of streetnumber, streettype and address is broken Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Blocks: 5575 Estimated Hours: 0.0 This manifests in the staff client -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-13 22:25:14 UTC --- Created attachment 3138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3138 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-13 22:26:08 UTC --- Created attachment 3139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3139 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3765, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4041 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-06 12:10:20 UTC --- This bug is mentioned in: Bug 5749 Fix borrower address display in intranet http://lists.koha-community.org/pipermail/koha-patches/2011-February/013842.... Bug 5749 follow up patch, whitespace cleanup http://lists.koha-community.org/pipermail/koha-patches/2011-February/013843.... Bug 5749 Fix borrower address display in intranet http://lists.koha-community.org/pipermail/koha-patches/2011-February/013852.... --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 04:30:52 UTC --- This has been signed off by Salvador Zaragoza Rubio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Pushed For QA --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 08:36:15 UTC --- Pushed for QA new/bug_5749 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Pushed For QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-02 17:47:46 UTC --- I'm not clear what the nature of the problem is, so it's difficult for me to evaluate the patch. Could a summary of the display breakage be given, as well as the circumstances required to bring it about? Screenshots encouraged. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-03 02:13:17 UTC --- Paul, (or someone from biblibre) any more information on this? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 07:58:11 UTC --- BibLibre Mantis number = 1416 (reported by SAN-OP) lorsqu'on utilise les zones de saisie numéro de voie et type de voie, l'adresse n'est pas correctement affichée sur la liste de recherche d'un adhérent ainsi que sur la fiche de l'adhérent => when you use streetnumber / streetype, the address is not correctly displayed on the patron result list and on the borrower detail. HTH -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3138|0 |1 is obsolete| | --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-04 13:38:40 UTC --- Created attachment 4843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4843 proposed patch (updated) QA comment * patch 1 contained a reference to .tmpl (removing an empty line). I've discarded this part of the patch * if your patron address, uses streetnumber and street type, were not displayed in result list or in detail before this patch, and are correctly displayed after. So this patch is OK * Major problem: It seems that the SetMemberInfosInTemplate sub added in C4/Members is NOT USED. So it should be removed. * Minor problem: The address on the left tab still does not contain streetnumber/type, it could be worth adding it here too Conclusion : * Marking Failed QA * will attach the patch with .tmpl removed * will affect the bug to Stephane Delaune, that submitted it (but is in holiday for 3 weeks) => Stéphane, please check if SetMemberInfosInTemplate is relevant or no, and argue or propose another patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA AssignedTo|paul.poulain@biblibre.com |stephane.delaune@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #10 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-05 12:27:29 UTC --- Comment 8 still does not provide a clear explanation of what the problem actually is. What does "not correctly displayed" mean? How does it display now, and how SHOULD it display? What data in what order? Screenshots would be helpful. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 12:48:34 UTC --- Ian: if you use street type and streetnumber, an address like "108 rue Breteuil" has 108 in streetnumber rue in streettype Breteuil in address Before this patch the display is BibLibre Breteuil 13006 Marseille After this patch the display is correct : BibLibre 108 rue Breteuil 13006 Marseille If you store everything in address, the patch has no consequence, it's displayed "108 rue Breteuil" as address="108 rue Breteuil" and streetnumber/streettype are empty Is it clear now ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-05 12:58:33 UTC --- Paul, Yes, very clear now, thank you. Patch can now be evaluated against a test condition. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #13 from Owen Leonard <oleonard@myacpl.org> 2011-08-05 17:11:52 UTC --- Is attachment 3139 obsoleted by attachment 4843? Many of the changes in attachment 4843 are also in the patch for Bug 5436. I'll consider this the feature-specific bug for the address display changes and remove them from Bug 5436. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3139|0 |1 is obsolete| | Attachment #4843|0 |1 is obsolete| | --- Comment #14 from stephane.delaune@biblibre.com --- Created attachment 8034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8034&action=edit proposed patch (updated) In effect, the patch of Bug 5436 (which is pushed in master) seems to make this bug almost obsolete. As Paul wrote, if you use street type and streetnumber, an address like "108 rue Breteuil" has : "108" in streetnumber, "rue" in streettype, "Breteuil" in address With the Bug 5436 the display is now "108 rue, Breteuil" instead of "108 rue Breteuil" this little patch corrects it (remove the comma). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P4 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8034|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8126&action=edit [SIGNED-OFF] Bug 5749 Fix borrower address display in intranet Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- I notice there are other problems with displaying addresses this way. For instance, circulation.pl and moremember.pl both use the same include file (circ-menu.inc), but only in circulation.pl does the [% address %] variable get built using street type, street number, and address: my $address = $borrower->{'streetnumber'}.' '.$roadttype_hashref->{$borrower->{'streettype'}}.' '.$borrower->{'address'}; I wonder why we're not doing this in the template instead? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, passed QA (In reply to comment #16)
I notice there are other problems with displaying addresses this way. For instance, circulation.pl and moremember.pl both use the same include file (circ-menu.inc), but only in circulation.pl does the [% address %] variable get built using street type, street number, and address:
my $address = $borrower->{'streetnumber'}.' '.$roadttype_hashref->{$borrower->{'streettype'}}.' '.$borrower->{'address'};
I wonder why we're not doing this in the template instead?
I think there's no specific reason to do it that way. Maybe that's a topic for next week, and defining "object" that will make a consistent display -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up pushed directly onto master, as the original branch new/bug_5749 was pre-3.4, so HTML::Template and the patch can't apply anymore -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org