[Bug 16114] New: Regression: Bug 14828 broke display of localized item type descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Bug ID: 16114 Summary: Regression: Bug 14828 broke display of localized item type descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/itemsearch.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you have defined a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages), the item type description is not displayed correctly in the item search form (catalogue/itemsearch.pl). Instead you see something like "Koha::Localization=HASH(0x849c980)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14828 | Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |14828 Severity|normal |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49410&action=edit Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49410|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49415&action=edit [SIGNED-OFF] Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49415|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49416&action=edit [PASSED QA] Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Bug 16114 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org