[Bug 25390] New: Login box is removed from opac-main.tt if Shibboleth or CAS is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 Bug ID: 25390 Summary: Login box is removed from opac-main.tt if Shibboleth or CAS is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On the OPAC main page (opac-main.tt) if CAS or Shibboleth are enabled than we remove the login box on the right side of the page (#login). I am wondering if this is necessary: 1. It does not remove local login functionality as you can still login via the modal in the top right corner. 2. In multi library systems this can be a problem as some might use a SSO service while others would like to see the login box on the right side. 3. Maybe it would be simpler to keep the login box regardless of sign in method and hide it via CSS for libraries that don't want it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the reasoning was that when you have a lot of different authentication methods activated they would clutter up the right column. Or the user would not find the Shibobleth/CAS options as they asssume they have to enter it there (where the other links don't show). Hope that makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #0)
3. Maybe it would be simpler to keep the login box regardless of sign in method and hide it via CSS for libraries that don't want it?
This is my inclination. Some libraries want both local login and SSO, while others don't. CSS is the easiest way to control this on a per-instance basis. Bug 31064 was designed to make it easier to control the display of the local login. That said, it looks like there are quite a few lines like "<p>If you do not have a Google account, but do have a local account, you can still log in: </p>" which are missing selectors at the moment... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33614 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Is this one still valid? I don't use CAS or Koha's Shibboleth implementation... just OpenID Connect and other mechanisms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to David Cook from comment #3)
Is this one still valid?
I don't use CAS or Koha's Shibboleth implementation... just OpenID Connect and other mechanisms
Yes this is still valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177144&action=edit Screenshot showing proposed form update It sounds like what we want is to show all login options unless 'opacShibOnly' is true? The attached screenshot shows updated buttons (making the Google button consistent with buttons for custom identity providers) and a generalized note to be shown if OAuth and/or other identity providers are enabled. I think we could even simplify the hint further: "If you have a local account you can log in below" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177145&action=edit Alternate proposal Here's a different version which follows other examples I've seen on the web. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Owen Leonard from comment #6)
Created attachment 177145 [details] Alternate proposal
Here's a different version which follows other examples I've seen on the web.
I like the alternative proposal, Owen. Many libraries like this style of login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #8 from Lisette Scheer <lisette@bywatersolutions.com> --- I also like having buttons with the options. I think the alternative looks a little nicer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Still a problem. Activate Shibboleth for the staff client only, and the login box disappears from the OPAC. I wonder if Owen had code for this, or if those images were just mockups? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I do have some code for this but I wasn't sure how to finish it. The main question I have is, Which login options should display at the same time? What, if any, should be exclusive? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- (In reply to Owen Leonard from comment #10)
I do have some code for this but I wasn't sure how to finish it. The main question I have is, Which login options should display at the same time? What, if any, should be exclusive?
Ah, that is tricky! My first thought is to have some sort of way to configure it, rather than trying to come up with logic that everyone can agree on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #12 from Chris Slone <cslone@camdencountylibrary.org> --- Definitely would like to see some implementation of this. Just as Magnus said, we have Shibboleth on for staff logins (only) right now, so we'd still like the log in box on the OPAC. Likewise think the Alternative layout looks a bit nicer, but a little bit of a moot point in our case. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org