http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31829&action=edit Bug 12979: Price formatting should only be defined at one place There are some places where the price format is defined. All these occurrences should be removed use the way introduced by bug 12844. Test plan: 1/ Verify you don't see any price formatting change on the basketgroup pdf (for layout2pages, payout2pagesde, layout3pages and layout3pagesfr). 2/ On admin/aqbudgetperiods.pl, the budget total should be unchanged too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Good catch Paola! Stupid error, it is fixed in the last patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979

Paola Rossi <paola.rossi@cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31829|0                           |1
        is obsolete|                            |

--- Comment #5 from Paola Rossi <paola.rossi@cineca.it> ---
Created attachment 31946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31946&action=edit
Bug 12979: Price formatting should only be defined at one place

I've applied against 3.17.00.025

>>git grep Number::Format
1) C4/Installer/PerlDependencies.pm:    'Number::Format' => {
2) Koha/Number/Price.pm:use Number::Format qw( format_price );
3) Koha/Number/Price.pm: return
Number::Format->new(%$format_params)->format_price($self->value);
4) Koha/Number/Price.pm: return
Number::Format->new(%$format_params)->unformat_number($self->value);
5) t/Number/Price.t:# How put the symbol at the end with Number::Format?

Everything is OK.

I pass the patch to "Signed Off" status.

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12984 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31946|0 |1 is obsolete| | Attachment #31947|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32574&action=edit [PASSED QA] Bug 12979: Price formatting should only be defined at one place There are some places where the price format is defined. All these occurrences should be removed use the way introduced by bug 12844. Test plan: 1/ Verify you don't see any price formatting change on the basketgroup pdf (for layout2pages, payout2pagesde, layout3pages and layout3pagesfr). 2/ On admin/aqbudgetperiods.pl, the budget total should be unchanged too. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4078 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4078 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Display active currency symbol on currency output and input -- You are receiving this mail because: You are watching all bug changes.