[Bug 41465] New: Unauthenticated request does not display 'type' correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Bug ID: 41465 Summary: Unauthenticated request does not display 'type' correctly Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |richard.bridgen@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190569&action=edit Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190569|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190570&action=edit Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190570|0 |1 is obsolete| | --- Comment #3 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 190592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190592&action=edit Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Richard Bridgen <richard.bridgen@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 192165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192165&action=edit Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Works great, I'd love if the type on this page and the table for authenticated users matched the display in the dropdown, but I think that's outside the scope of this bug. I'll file (or find) a seperate bug for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190592|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 192166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192166&action=edit Bug 41465: Fix display of 'type' for unauthenticated ILL request 'request' is unblessed in this context. get_type doesnt exist/work. Test plan: 1) Enable ILLModule and ILLOpacUnauthenticatedRequest 2) Logout, place an OPAC unauthenticated ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Input all mandatory fields. Click 'Create'. 4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. 5) Apply patch. Repeat. Notice 'Request type' now shows as expected. Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The feature has been introduced in 25.05, won't be backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41465 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Manual. Unauthenticated requests are being documented (by me) as part of bug 36197. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org