[Bug 35844] New: Default for `OPACSearchForTitleIn` syspref misses class assignment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35844 Bug ID: 35844 Summary: Default for `OPACSearchForTitleIn` syspref misses class assignment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: alexander.wagner@desy.de QA Contact: testopia@bugs.koha-community.org `OPACSearchForTitleIn` allows to pass on an OPAC search to some external services and triggers a sub menu on the OPAC details page. It is configured via HTML and the current default reads: ```html <a href="https://worldcat.org/search?q={TITLE}" target="_blank">Other Libraries (WorldCat)</a> <a href="https://scholar.google.com/scholar?q={TITLE}" target="_blank">Other Databases (Google Scholar)</a> <a href="https://www.bookfinder.com/search/?author={AUTHOR}&title={TITLE}&st=xl&ac=qr" target="_blank">Online Stores (Bookfinder.com)</a> <a href="https://openlibrary.org/search?author=({AUTHOR})&title=({TITLE})" target="_blank">Open Library (openlibrary.org)</a> ``` As on the very same page there is also the sub menu for `Save record` it seems save to assume that both should look identical. However, the above html stub misses to assign `class="dropdown-item"` to the links to achieve this. Most likely the above html should read ``` html <a class="dropdown-item" href="https://worldcat.org/search?q={TITLE}" target="_blank">Other Libraries (WorldCat)</a> <a class="dropdown-item" href="https://scholar.google.com/scholar?q={TITLE}" target="_blank">Other Databases (Google Scholar)</a> <a class="dropdown-item" href="https://www.bookfinder.com/search/?author={AUTHOR}&title={TITLE}&st=xl&ac=qr" target="_blank">Online Stores (Bookfinder.com)</a> <a class="dropdown-item" href="https://openlibrary.org/search?author=({AUTHOR})&title=({TITLE})" target="_blank">Open Library (openlibrary.org)</a> ``` which gets the class assignment for both menues in sync. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36805 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35844 Michał <schodkowy.omegi-0r@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schodkowy.omegi-0r@icloud.c | |om --- Comment #1 from Michał <schodkowy.omegi-0r@icloud.com> --- It definitely looks like an omission after some CSS refactor. I'll add to it that adding said class would also have to be added to the update scripts, to fix this in all the existing installations! Maybe replacing `<a href=` with `<a class="dropdown-item" href=`, but such naive approach is certainly not ideal for obvious reasons. If Koha has some Perl module for HTML parsing included, and if it's non-destructive to the layout apart from changing the explicitly changed items, then the best course of action would be to use that and then add/expand the `class` attribute, in case someone's links already have `class`... This definitely seems like pain. The former lazier solution in theory should fix 99% of cases, while risking the remaining rounded-up 1% to be broken and having to figure out things manually in worst case scenario. Might be acceptable, since it's expected that various manual Koha HTML/JS/CSS customizations might need adjustment after major upgrades. Also the fact that there's that other bug that proposes moving away from using HTML at all, it hardly justifies then spending a lot of time on some advanced HTML-parsing migration script rather than dead simple one. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org