[Bug 9669] New: Replace YUI buttons on staff client cart toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Bug ID: 9669 Summary: Replace YUI buttons on staff client cart toolbar Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/basket/basket.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the staff client cart page are generated using YUI markup. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15562&action=edit Bug 9669 - Replace YUI buttons on staff client cart toolbar This patch converts the toolbar on the staff client cart page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the staff client cart and confirm that all buttons look correct and work correctly. Functions to test include: Full/brief display Send Download (various options) Print Empty and close Hide window -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15562|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15563&action=edit [SIGNED-OFF] Bug 9669 - Replace YUI buttons on staff client cart toolbar This patch converts the toolbar on the staff client cart page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the staff client cart and confirm that all buttons look correct and work correctly. Functions to test include: Full/brief display Send Download (various options) Print Empty and close Hide window Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tested all buttons, works very well. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- In my case when trying to download BibTeX, got Software error, but the same is without patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Looks good, no regression found, All works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15563|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15770&action=edit Bug 9669 - Replace YUI buttons on staff client cart toolbar This patch converts the toolbar on the staff client cart page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the staff client cart and confirm that all buttons look correct and work correctly. Functions to test include: Full/brief display Send Download (various options) Print Empty and close Hide window Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tested all buttons, works very well. No errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org