[Bug 22432] New: Star ratings plugin replacement missing from a couple pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Bug ID: 22432 Summary: Star ratings plugin replacement missing from a couple pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: bibliwho@gmail.com, dilan@calyx.net.au, jonathan.druart@bugs.koha-community.org, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, mtj@kohaaloha.com, nick@bywatersolutions.com, pierre-marc.thibault@inlibro.com, testopia@bugs.koha-community.org Depends on: 10659 Target Milestone: --- The upgrade of the star ratings plugin missed a couple of pages: Overdrive search results and Recorded Books search results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 [Bug 10659] Upgrade jQuery star ratings plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any movement on this one Owen? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87011&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87011|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87062&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think anyone else has credentials to both Overdrive and RecordedBooks (I don't). Patch looks sensible and passes tests. I am inclined to pass QA trusting Nick and Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87062|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87242&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug in enhancement 10659 not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org