[Bug 31813] New: Information on manage MARC import details page is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Bug ID: 31813 Summary: Information on manage MARC import details page is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Blocks: 30952 When looking at an imported MARC file details, you have on top: Matching rule applied No matching rule in effect Action if matching record found: Add incoming record Action if no match found: Add incoming record Item processing: Always add items These are misaligned now. Please keep enough space here for longer translations! Also: We are missing a colon! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Information on manage MARC |Specify white-space: normal |import details page is |for spans styled as labels |misaligned | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142081&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a <span> with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30952 | Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142099&action=edit Screenshots of manage staed MARC records - before and after I'm not noticing any differences (see screenshots, even though they are from two different batches). Am I looking in the right place? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #2)
Am I looking in the right place?
Sorry I see my test plan is incorrect: The problem happens when you're viewing a batch which has been staged *and* imported. Before the import those form controls are still visible. After the import they're not and you'll see the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142081|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 142196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142196&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a <span> with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 142197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142197&action=edit Bug 31813: (follow-up) Add missing colon for managed staged MARC records Add colon after "Matching rule applied" when viewing details for a batch already imported. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #3)
Sorry I see my test plan is incorrect: The problem happens when you're viewing a batch which has been staged *and* imported. Before the import those form controls are still visible. After the import they're not and you'll see the issue.
Thanks Owen! I can see it now. I added a follow-up for the missing colon - happy to add to another bug if this preferred. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The wrapping is good, of course, but why do we limit the rather long labels to such a small column? It would also help with the even longer German translations to give a bit more space :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142196|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142451&action=edit Bug 31813: Specify white-space: normal for spans styled as labels This patch is necessary to override a CSS property being inherited from Bootstrap. Allowing a <span> with the "label" class to wrap will keep alignment correct when displaying information in the same layout as a form. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, stage a batch of MARC files (Cataloging -> Stage MARC records for import). - Go to Cataloging -> Manage staged MARC records and click on one of the batches to view the details. - In the list of information about the batch, longer labels like "Matching rule applied" should wrap so that they stay aligned with other labels in the list. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142197|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142452&action=edit Bug 31813: (follow-up) Add missing colon for managed staged MARC records Add colon after "Matching rule applied" when viewing details for a batch already imported. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974 [Bug 31974] Regression: Bug 31813 incorrectly affected labels in the header search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31813 Bug 31813 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org