[Bug 35007] New: Self checkout system (SCO) - table heading row background colour in tabs is inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Bug ID: 35007 Summary: Self checkout system (SCO) - table heading row background colour in tabs is inconsistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org In the OPAC self checkout system, the tables in the tabs (such as Checkouts, Holds, and Charges) have different header row colours. For the checkouts tab, the header row is consistent with other tables in the OPAC. For the other tabs (such as Checkouts and Holds), the table heading row has a white background. To replicate (using KTD): 1. Enable the SelfCheckInModule and WebBasedSelfCheck system preferences (if not already enabled). 2. Check out some items to the koha user. 3. Place some holds for the koha user. 4. Add a charge to the koha user (Patrons > koha (42) > Accounting > Create manual invoice). 5. Go to the self checkout system page: <yourlocalhostname>:8080/cgi-bin/koha/sco/sco-main.pl 6. Log in as the koha user 7. Note that: - for the Checkouts tab: the table has a coloured background and looks consistent with other tables in the OPAC - for the other tabs (Holds and Charges): the table heading row for both tables has a white background -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156754&action=edit Screenshot showing DataTables controls The table style differences on this page are due to the fact that the checkouts table is a DataTable and the others are not. We could modify the CSS so that they match, but I think we might like to make the holds and account tables DataTables. Since I'm copying DT initialization from opac-user.tt I wonder: Should we include copy/csv/print buttons like we do on that page? See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #2 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #1)
Since I'm copying DT initialization from opac-user.tt I wonder: Should we include copy/csv/print buttons like we do on that page? See attached screenshot.
It wouldn't hurt, but I'm not sure whether a patron would use them - but you never know! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self checkout system (SCO) |Configure self checkout |- table heading row |tables consistently |background colour in tabs | |is inconsistent | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156803&action=edit Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156803|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 156805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156805&action=edit Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156805|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156874&action=edit Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- We may want a way to easily hide the table controls, not sure if there is a simple CSS, but some libraries won't have a printer hooked up, or the table might not print nice to a receipt printer, but I don't think including by default hurts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase ASAP. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156874|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157794&action=edit Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Conflicts when backport 23.05.x on : koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Please create a dedicated patch if backport is wanted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #7)
We may want a way to easily hide the table controls, not sure if there is a simple CSS
Putting this in SCOUserCSS seems to work: .buttons-copy, .buttons-csv, .buttons-print { display: none; } or if you don't want the search filter either: .table_controls { display: none; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37027 [Bug 37027] Some dataTable controls in SCO seem unnecessary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35007 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org