https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25393 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- I think this was a choice on 25393 - to mark that a checkout had auto-renewals enabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 [Bug 25393] Create separate 'no automatic renewal before' rule -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Mirjam Vantieghem from comment #0)

Since 23.11, on the checkouts page both in Staff client and OPAC, when a certain item is not renewable, e.g. because it is on hold or max renewals reached, the text "Scheduled for automatic renewal" still appears which is confusing.

E.g. In the OPAC it says "Not renewable (on hold)", but right below it, it still says "This item is scheduled for auto renewal." In the Staff client it shows "On hold" and below that "(Scheduled for automatic renewal)".

Are you able to provide a detailed test plan to reproduce this? Also current values of "No renewal before", "No automatic renewal before" and "Automatic renewal" in the circulation rules. It may be that there is no bug here, as both messages being shown is an expected use case, I believe. It may be that in the situation you describe, a manual renewal is not possible "right now" (because its on hold) but an automatic renewal **attempt** is still going to happen for that specific checkout when the time for the cron to run comes, hence the message. It may be the case that the hold is cancelled in the meantime, and in such event the automatic renewal would succeed, hopefully. I agree that the text being presented may be confusing, but this was done for transparency reasons, i.e. provide full information of what is going on. The alternative would be to just show "Not renewable (on hold)" and nothing else, but an auto renewal attempt would still take place for that checkout eventually. I'm not saying there is no bug here, but the above is the reasoning behind the implementation decisions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Myka Kennedy Stephens <mkstephens@fosgail.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@fosgail.org --- Comment #4 from Myka Kennedy Stephens <mkstephens@fosgail.org> --- Here's another idea that might be simpler but have the same effect. What if the text "Scheduled for automatic renewal" was changed to something like "Automatic renewal enabled"? Would this still communicate the same information (auto-renew is turned on) without implying that an actual renewal is scheduled and pending? Just changing the text means that the two messages would continue to appear together when no renewals were remaining. If it is still too confusing to see an auto-renew message when no renewals are remaining, then it would be ideal for the visibility of the auto-renew message to reference the renewal status so that it would not appear when an item is not renewable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Mwoo <mary.woodward@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward@bedfordtx.gov --- Comment #5 from Mwoo <mary.woodward@bedfordtx.gov> --- I think removing the second line of text "This item is scheduled for automatic renewal" would be less confusing for patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #7 from Kristi <kkrueger@cuyahogalibrary.org> --- I also just noticed today that the message "Scheduled for automatic renewal" appears for patrons opted out of automatic renewals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Kristi Krueger from comment #7)

I also just noticed today that the message "Scheduled for automatic renewal" appears for patrons opted out of automatic renewals.

Noticing the same thing as well in 24.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org --- Comment #9 from mteal@greenvillelibrary.org --- This is an issue for us as well - it's confusing for staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to mteal from comment #10)

It looks like the original intent of this bug was written up regarding a patron signed up for automatic renewal, but the "Scheduled for automatic renewal" shows up for items checked out are not eligible for renewal. Should the issue that "Scheduled for automatic renewal" shows up for patrons who have opted out of automatic renewals be a separate bug? It doesn't seem like this part would be as complicated to address as the original issue.

That's a good question... I think you're probably right. Looking at the OP... yeah I suppose that is a different issue. We do have the output of CanBookBeRenewed at hand in svc/checkouts, but we'd need to interrogate it and do lots of if/elsif/elses I think. It would probably be a bit of work but it might be worthwhile to do... -- Looking at "svc/checkouts", it looks like it just reports "auto_renew" enabled if auto_renew is enabled for the checkout. That endpoint should probably also show borrowers.autorenew_checkouts, and then only show "Scheduled for automatic renewal" in koha-tmpl/intranet-tmpl/prog/js/checkouts.js if both oObj.auto_renew and oObj.patron_auto_renew are true. Since I think ./misc/cronjobs/automatic_renewals.pl only selects checkouts where both the item has auto_renew and the borrower has autorenew_checkouts... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #13 from David Cook <dcook@prosentient.com.au> --- *** Bug 40775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- I have opened bug 41518 to only show "Scheduled for automatic renewal" if issue.auto_renew and borrowers.autorenew_checkouts are both set, since that's the criteria required for automatic_renewals.pl to consider the issues for automatic renewal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021 --- Comment #16 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to David Cook from comment #12)

Looking at the original description again... I think as Nick said in Comment 1... maybe it does make sense saying it's scheduled for automatic renewal even if it's not renewable. Because the automatic renewal script will still check it. And if they get notices they might get a notice saying that the automatic renewal has failed.

I think in this case "Scheduled for automatic renewal" just means that it's flagged as an automatic renewal item.

Hmm... I could see both sides of that.

As I said in Bug 40775, ideally it could be context aware. Regardless of whether or not something is flagged for autorenewal, a patron wants to know if it is going to renew. I think everyone appreciates that might change, but knowing in the present moment is helpful. We actually tried toggling that column off to prevent confusion, but a number of patrons said that they checked the column to see what items they should read or watch first so they could get the items back for the person waiting; we want to encourage that sort of behavior. I think it's especially frustrating to show that if the autorenewal limit has been reached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.