[Bug 41588] New: Link from 856$u breaks with leading or trailing spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Bug ID: 41588 Summary: Link from 856$u breaks with leading or trailing spaces Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Leading or trailing spaces in the 856$u add "%20" to the url, breaking it. To recreate: - add 856$u "www.cheese.com" to a record; it works! - add 856$u " www.cheese.com" to a record; it doesn't work - add 856$u "www.cheese.com " to a record; it doesn't work We've got a syspref to strip those characters out when editing a record, but we may as well also deal with spaces in the XSLT for old records and/or libraries that haven't enabled the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41081 [Bug 41081] Link from 856$u points to http://%20%20%20%20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41081 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 191217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191217&action=edit Bug 41588: Normalize spaces in 856$u links To test: 1 - add 856$u " www.cheese.com" to a record 2 - confirm link does not work from results or details in either staff interface or OPAC 3 - add 856$u "www.cheese.com " to a record 4 - confirm link does not work from results or details in either staff interface or OPAC 7 - apply patch, restart_all 8 - reload pages, confirm both links work in results and details in staff interface and OPAC Optional final step: have some cheese as a treat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191218&action=edit Bug 41588: Normalize spaces in 856$u links To test: 1 - add 856$u " www.cheese.com" to a record 2 - confirm link does not work from results or details in either staff interface or OPAC 3 - add 856$u "www.cheese.com " to a record 4 - confirm link does not work from results or details in either staff interface or OPAC 7 - apply patch, restart_all 8 - reload pages, confirm both links work in results and details in staff interface and OPAC Optional final step: have some cheese as a treat Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If a 856$u for a record had release notes| |spaces before or after the | |URL, the link shown on the | |record page on the OPAC and | |staff interface (under | |'Online resources') did not | |work. | | | |Depending on the browser, | |either nothing happened, or | |an error was shown that the | |site wasn't reachable. | | | |Examples that previously | |caused links not to work | |(without the quotes): | |- " koha-community.org" | |- "koha-community.org " | |- " koha-community.org " CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191218|0 |1 is obsolete| | --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 192533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192533&action=edit Bug 41588: Normalize spaces in 856$u links To test: 1 - add 856$u " www.cheese.com" to a record 2 - confirm link does not work from results or details in either staff interface or OPAC 3 - add 856$u "www.cheese.com " to a record 4 - confirm link does not work from results or details in either staff interface or OPAC 7 - apply patch, restart_all 8 - reload pages, confirm both links work in results and details in staff interface and OPAC Optional final step: have some cheese as a treat Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jan.kissig@th-wildau.de |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de QA Contact|jan.kissig@th-wildau.de |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6892 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 --- Comment #5 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41588 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 41081 not in 24.11.x Not a real dependency but I prefer not impact LTS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org