[Bug 33810] New: Accessibility: OPAC Advanced Search fields are not labelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Bug ID: 33810 Summary: Accessibility: OPAC Advanced Search fields are not labelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The OPAC Advanced Search fields are not labelled and have been failed in an Accessibility report carried out by the Shaw Trust for the British Museum. The search field dropdowns do not have any labelling at all and the text inputs have a title, rather than a label element or an aria-label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |matt.blenkinsop@ptfs-europe | |.com Blocks| |25423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 [Bug 25423] Methods update and empty from Koha::Objects are not class methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151577&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks|25423 |25243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 [Bug 25423] Methods update and empty from Koha::Objects are not class methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33812 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- "Choose search field 1," "Choose search field 2," etc seem a little unclear to me. What about "Choose search type for field 1" ? Then perhaps the text input could also refer to the field number? "Enter field 1 search terms" ? That might help the user understand the context. I also think this patch should address the search operator dropdowns that appear if you click the "More options" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151577|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151618&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Thanks Owen, I've updated the patch. For the "More Options" fields, all of those dropdowns already have labels with a "for" attribute so I don't think they are currently an issue for screen reading. Unless you want some aria-labels with more specific descriptions? let me know and I can take a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Johanna Miettunen <johanna.miettunen@haaga-helia.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.miettunen@haaga-hel | |ia.fi --- Comment #5 from Johanna Miettunen <johanna.miettunen@haaga-helia.fi> --- Can you please give instructions how to test this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Johanna Miettunen from comment #5)
Can you please give instructions how to test this.
I think this browser extension is a good option: https://addons.mozilla.org/en-US/firefox/addon/wave-accessibility-tool/ (Firefox version) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151618|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154493&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154493|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154498&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs Signed-off-by: joubu <xxx@example.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stephane.delaye@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Edith Speller <edith.speller@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk --- Comment #9 from Edith Speller <edith.speller@ukhsa.gov.uk> --- Hello, I'm new to Bugzilla so I don't know if it's right to comment on a bug that's been signed off! Sorry if I am breaching etiquette. I agree the bugfix is an improvement and makes the change as described. However: a) the operator dropdowns (name="op") accessed when clicking 'more options' are still not labelled b) there's still no *visible* labels for the advanced search index fields. I suspect b) needs a new bug to be opened as would need to add visible text labels for the index dropdowns (name="idx"). The search boxes could be aria-labelledby the selected option in the corresponding index dropdown if each option could be given an ID to enable this. Context: https://www.w3.org/WAI/WCAG21/Understanding/labels-or-instructions.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154498|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 157579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157579&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs Signed-off-by: joubu <xxx@example.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the accessibility improvement! Marking this as a bug because a missing accessibility feature is a bug, not an enhancement IMO. Edith - thanks for the input! I am seeing labels on those elements now (unless I'm misunderstanding which sections you're referring to). Can you take another look, and file a new bug (and mark which Koha version you're using) if there is still something missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org