[Bug 31635] New: Empty title for current result in opac results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Bug ID: 31635 Summary: Empty title for current result in opac results browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org This is very minor, but I noticed it when working on bug 31634. When using OpacBrowseResults, there are result number buttons at the top of the results browser. If you hover over those result numbers, it says 'View record "[title]"'. But if you hover over the current result number, it only says 'View record ""' (with nothing between the double quotes). To test: 1. Make sure OpacBrowseResults is enabled 1.1. In Koha staff interface, go to Administration > Global system preferences 1.2. Search for OpacBrowseResults 1.3. If necessary, change to 'enable' and click 'Save all OPAC preferences' 2. In OPAC, search for a term that will give you a couple of results and view the results browser 2.1. In Koha OPAC, search for BFF 2.2. Click on one of the titles to access the opac-detail page 3.3. Click 'Browse results' 3.4. Hover over the number buttons at the top of the results browser --> When you hover over another result, it says 'View record "[title]"' -- OK --> When you hover over the current result, it says 'View record ""' -- should say the title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think it has to do with the fact that the other results are "listitems" of "listResults" whereas the current result is not one of those listitems. I had a similar problem when trying to work out how to solve bug 31634, I was able to add the part_number and part_name for the current result, but I had to do some acrobatics to add them for the other results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141301&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty title for current |Empty title for current |result in opac results |result in OPAC results |browser |browser -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141301|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141332&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141332|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141532&action=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty title for current |Empty title for current |result in OPAC results |result in OPAC results |browser |browser's tooltip on paging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #6 from Pablo AB <pablo.bianchi@gmail.com> --- Will be backported to 22.05? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org