https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113262&action=edit Bug 26958: Move Elasticsearch mapping template JS to the footer This patch moves inclusion of JavaScript to the footer of the Elasticsearch mapping template. It also moves the JS into a separate file. To test you should have SearchEngine system preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch). - Confirm that JavaScript dependent interactions work correctly: - Tabs - Under the bibliographic records and authorities tabs, table row drag-and-drop - Under the bibliographic records and authorities tabs, test the "Add" line at the bottom of the table. - Under the bibliographic records and authorities tabs, test the "Delete" button. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113262|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 113299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113299&action=edit Bug 26958: Move Elasticsearch mapping template JS to the footer This patch moves inclusion of JavaScript to the footer of the Elasticsearch mapping template. It also moves the JS into a separate file. To test you should have SearchEngine system preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch). - Confirm that JavaScript dependent interactions work correctly: - Tabs - Under the bibliographic records and authorities tabs, table row drag-and-drop - Under the bibliographic records and authorities tabs, test the "Add" line at the bottom of the table. - Under the bibliographic records and authorities tabs, test the "Delete" button. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26970 [Bug 26970] Add row highlight on drag in Elasticsearch mapping template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 113301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113301&action=edit Bug 26970: Add row highlight on drag in Elasticsearch mapping template In Elasticsearch mapping tables : In order to better see which row is currently in drag-an-drop, add an highlight color like in circulation and fine rules when editing a row. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) In each table : biblio, authorities, facets 3) Clik on a row to start a drag => See row turning orange 4) Release to drop => See row turning back to original color -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113299|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116759&action=edit Bug 26958: Move Elasticsearch mapping template JS to the footer This patch moves inclusion of JavaScript to the footer of the Elasticsearch mapping template. It also moves the JS into a separate file. To test you should have SearchEngine system preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch). - Confirm that JavaScript dependent interactions work correctly: - Tabs - Under the bibliographic records and authorities tabs, table row drag-and-drop - Under the bibliographic records and authorities tabs, test the "Add" line at the bottom of the table. - Under the bibliographic records and authorities tabs, test the "Delete" button. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26958 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.