[Bug 29207] New: Restore Getopt::Long config to not ignore cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Bug ID: 29207 Summary: Restore Getopt::Long config to not ignore cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600#c1 removed ":config no_ignore_case" making Getopt::Long not being able to differentiate -d and -D options, which caused problems with starting Z39.50/SRU. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 126045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126045&action=edit Bug 29207: Getopt::Long should not ignore cases To avoid Getopt::Long treating upper case and lower case options, this patch restores removed ":config no_ignore_case". Steps to reproduce: 1. Start koha-z3950-responder deamon for any instance. 2. Check z3950.log log file, there should be "[fatal] Failed to listen on ...-koha-z3950" in it. 3. Alternatively you can "curl localhost:2100/biblios?version=1.1 -v" to ensure that it doesn't work "Failed to connect to localhost port 2100: Connection refused". 4. Apply the patch. 5. Stop and start daemon again. 6. Check the logs again, there should be no new error there. 7. Same way do the curl to ensure that this time it listens on that port. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 --- Comment #2 from Andrew Nugged <nugged@gmail.com> --- QA note: yet we had only one option how to check that case problem araised, two other places where no_ignore_case were removed (looks like accidentally, but JD, we need your confirmation that it should be restored in all places). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Keywords| |rel_21_11_candidate --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- That's definitely an error caused by the script that generated bug 17600. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126045|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126686&action=edit Bug 29207: Getopt::Long should not ignore cases To avoid Getopt::Long treating upper case and lower case options, this patch restores removed ":config no_ignore_case". Steps to reproduce: 1. Start koha-z3950-responder deamon for any instance. 2. Check z3950.log log file, there should be "[fatal] Failed to listen on ...-koha-z3950" in it. 3. Alternatively you can "curl localhost:2100/biblios?version=1.1 -v" to ensure that it doesn't work "Failed to connect to localhost port 2100: Connection refused". 4. Apply the patch. 5. Stop and start daemon again. 6. Check the logs again, there should be no new error there. 7. Same way do the curl to ensure that this time it listens on that port. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126686|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126802&action=edit Bug 29207: Getopt::Long should not ignore cases To avoid Getopt::Long treating upper case and lower case options, this patch restores removed ":config no_ignore_case". Steps to reproduce: 1. Start koha-z3950-responder deamon for any instance. 2. Check z3950.log log file, there should be "[fatal] Failed to listen on ...-koha-z3950" in it. 3. Alternatively you can "curl localhost:2100/biblios?version=1.1 -v" to ensure that it doesn't work "Failed to connect to localhost port 2100: Connection refused". 4. Apply the patch. 5. Stop and start daemon again. 6. Check the logs again, there should be no new error there. 7. Same way do the curl to ensure that this time it listens on that port. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords|rel_21_11_candidate | QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Bug 29207 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Bug 29207 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org