[Bug 27734] New: OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Bug ID: 27734 Summary: OpacHiddenItems produces a 404 from borrower holds list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mfuerst@hmcpl.org QA Contact: testopia@bugs.koha-community.org When a borrower clicks on a hold in their holds list they have placed on a title that was subsequently hidden with OpacHiddenItems, it results in a 404 error instead of the "This record is blocked" error page. It seems like OpacHiddenItems should work the same as individually suppressed records and how they are handled in OpacSuppressionRedirect. This would make more sense from the user's perspective. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121749&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121749|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 121797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121797&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121797|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121988&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121989&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121990&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead? See bug 26050. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead?
See bug 26050.
Actually, I think you are right. It would also be fair, since we had a similar thing just rewritten and this is a quite new patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- *** This bug has been marked as a duplicate of bug 22286 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Sorry, I got the duplicity backwards! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- *** Bug 22286 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #11 from Pablo AB <pablo.bianchi@gmail.com> --- This seems to be strongly related to bug 9966. The staff should be able to let access to bibliographic info even if all items are hidden (similar as with biblios without items). Else, show an appropriate message instead of 404. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|acampbell@hmcpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121990|0 |1 is obsolete| | --- Comment #12 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 173166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173166&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #13 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 173167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173167&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch replaces OpacHiddenRecordMessage preference with a HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- I've rebased the original patch and added a new patch that replaces OpacHiddenRecordMessage system preference with an HTML customization entry of the same name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173167|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 173168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173168&action=edit Bug 27734: Replace OpacHiddenRecordMessage system preference with HTML customization This patch replaces OpacHiddenRecordMessage preference with an HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173166|0 |1 is obsolete| | Attachment #173168|0 |1 is obsolete| | --- Comment #16 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 175807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175807&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #17 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 175808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175808&action=edit Bug 27734: Replace OpacHiddenRecordMessage system preference with HTML customization This patch replaces OpacHiddenRecordMessage preference with an HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas, you are still QA contact here, could you take another look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38936 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Feels like opac-MARCdetail and opac-ISBDdetail will need adjustement. We should follow what has been done on bug 38936. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org --- Comment #20 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This needs to be redone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175807|0 |1 is obsolete| | Attachment #175808|0 |1 is obsolete| | --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188253&action=edit Bug 27734: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #22 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188254&action=edit Bug 27734: Add C4::Output::redirect_if_opac_hidden() To test: 1. prove t/db_dependent/Output.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #23 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188255&action=edit Bug 27734: Use redirect_if_opac_hidden() in opac-*detail.pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188256&action=edit Bug 27734: Add OpacHiddenRecordRedirect system preference This patch adds option analogous to OpacSuppressionRedirect for OpacHiddtenItems Test plan: 1. Apply patch 2. Create a bibiliographic record and add an item to it. Note down its biblionumber. It will be later reffered to as <biblionumber>. 3. Set system preference OpacHiddenRecordRedirect on 4. Create HTML customization OpacHiddenRecordMessage. Add some placeholder content in it. 5. Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [<biblionumber>] e.g. biblionumber: [123] 6. Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 7. Hit these links: http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<biblionumber> 8. When OpacHiddenRecordRedirect set to 404 you get a 404 9. When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 10. If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl 11. Using preference OpacHiddenItemsExceptions, exclude your patron category 12. Observe the record is no longer blocked when your patron category is excluded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188253|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 190812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190812&action=edit Bug 27734: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188254|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 190813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190813&action=edit Bug 27734: Add C4::Output::redirect_if_opac_hidden() To test: 1. prove t/db_dependent/Output.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188255|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 190814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190814&action=edit Bug 27734: Use redirect_if_opac_hidden() in opac-*detail.pages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188256|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 190815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190815&action=edit Bug 27734: Add OpacHiddenRecordRedirect system preference This patch adds option analogous to OpacSuppressionRedirect for OpacHiddtenItems Test plan: 1. Apply patch 2. Create a bibiliographic record and add an item to it. Note down its biblionumber. It will be later reffered to as <biblionumber>. 3. Set system preference OpacHiddenRecordRedirect on 4. Create HTML customization OpacHiddenRecordMessage. Add some placeholder content in it. 5. Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [<biblionumber>] e.g. biblionumber: [123] 6. Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 7. Hit these links: http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<biblionumber> 8. When OpacHiddenRecordRedirect set to 404 you get a 404 9. When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 10. If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl 11. Using preference OpacHiddenItemsExceptions, exclude your patron category 12. Observe the record is no longer blocked when your patron category is excluded Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
Holds 1.3 Click on the link to the item on hold. Success! You can see the record. 1.4 For OpacHiddenItems, add: biblionumber: [262] 1.5 Repeat step 1.3 1.6 You get the "An error has occurred page": Sorry, the requested page is not available Error 404
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #29 from David Nind <david@davidnind.com> --- I've signed off, but have some feedback: 1. System preference description: - "..opac.." should be OPAC - for the option "an explanatory page ('This record is blocked').", the title of the page generated is "Record blocked", so the option for the system preference should match. - for "..redirect page for suppressed bibliographic records...", I think that should be "..hidden..", as this is what we use in the sentence above and in the system preference name 2. With the "explanatory page" option, I found it odd that the title and message are hard-coded. That is, we are adding a way to add a custom page for the 404, but then are hard-coding a What is displayed if the "explanatory page" option is selected: Record blocked You are not authorized to view this record. [Then anything in OpacHiddenRecordMessage] Testing notes (using KTD): 1. To reproduce the issue: 1.1 Place a hold on a record for a patron (I used Programming Perl, 262) 1.2 Log in to the OPAC as that patron and go to Your account > Your summary 2. Apply the patch 3. Update the database: updatedatabase 4. Restart everything: restart_all 5. For step 2 of the test plab: I used an existing record, CGI programming with Perl (11), which has one item 6. For step 3: OpacHiddenRecordRedirect is on by default (set to 'Hide') 7. For step 5: OpacHiddenItems - biblionumber: [11] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org