[Bug 18398] New: CHECKIN/CHECKOUT/RENEWAL don' t use AutoEmailPrimaryAddress but first valid e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Bug ID: 18398 Summary: CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If the system preference AutoEmailPrimaryAddress is set to alternate or work this e-mail addresses should be used to send out all emails. This works for most notices, but sadly not for CHECKIN, CHECKOUT and RENEWAL notices. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Message.pm;hb=7... sub _to_address is hardcoded to use the first e-mail field that is set in the patron record. It should follow the AutoEmailPrimaryAddress setting instead. Bug 12802 fixed it, but it's a new feature. Woudl still be good to fix this especially for stable releases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid, especially since bug 12802 is currently sitting in FQA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- They are still added as pending, being moved to 'failed' when the message queue is processed. Still wondering if this makes sense? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 20228 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148053&action=edit Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address This patch updates the enque method in C4::Message to expect a Koha::Patron object in the parameters and then uses that patron object to select the correct email address for notices as defined by AutoEmailPrimaryAddress. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This affects the notices Katrin mentions and also Recalls notices as that module has since been pushed and also uses the C4::Message module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29046 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33192 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Behold, the monstruous test plan! *thunder crackles* To test CHECKIN/CHECKOUT/RENEWAL with AutoEmailPrimaryAddress 1. Set RenewalSendNotice to 'Send' 2. Change email addresses of a patron (I used Edna Acosta) - In the 'Primary email' field, enter something like primary@... - In the 'Secondary email' field, enter something like secondary@... - In the 'Email' field of the 'Alternate address' section, enter something like alternate@... 3. Change messaging preferences of the same patron - Item check-in = email - Item checkout and renewal = email 4. Set AutoEmailPrimaryAddress to primary email address (home) 5. Check out an item to the patron 6. Check the to_address in the message_queue table for CHECKOUT, it should be primary@... select to_address, letter_code, time_queued from message_queue where date(time_queued) = curdate(); 7. Renew the checkout 8. Check the to_address in the message_queue table for RENEWAL, it should be primary@... select to_address, letter_code, time_queued from message_queue where date(time_queued) = curdate(); 9. Check in the item 10. Check the to_address in the message_queue table for CHECKIN, it should be primary@... select to_address, letter_code, time_queued from message_queue where date(time_queued) = curdate(); 11. Delete the messages from the message_queue. delete from message_queue where to_address like 'primary%'; 12. Change AutoEmailPrimaryAddress to secondary email address (work) 13. Redo steps 5 to 10. The address in the message_queue table should now be secondary@... 14. Delete the messages from the message_queue. delete from message_queue where to_address like 'secondary%'; 15. Change AutoEmailPrimaryAddress to alternate email address (alternate) 16. Redo steps 5 to 10. The address in the message_queue table should now be alternate@... 17. Delete the messages from the message_queue. delete from message_queue where to_address like 'alternate%'; 18. Change AutoEmailPrimaryAddress to cardnumber as 19. Redo steps 5 to 10. The address in the message_queue table should now be the patron's cardnumber 20. Delete the messages from the message_queue. delete from message_queue where to_address = '23529001000463'; 21. Change AutoEmailPrimaryAddress to first valid 22. Redo steps 5 to 10. The address in the message_queue table should now be primary@... 23. Delete the messages from the message_queue. delete from message_queue where to_address like 'primary%'; 24. Remove the patron's primary email address 25. Redo steps 5 to 10. The address in the message_queue table should now be secondary@... 26. Delete the messages from the message_queue. delete from message_queue where to_address like 'secondary%'; 27. Remove the patron's secondary email address 28. Redo steps 5 to 10. The address in the message_queue table should now be alternate@... 29. Delete the messages from the message_queue. delete from message_queue where to_address like 'alternate%'; 30. Remove the patron's alternate email address 31. Redo steps 5 to 10. The address in the message_queue table should now be empty To test RECALLS with AutoEmailPrimaryAddress 0. Set up recalls (see bug 19532) 1. Change email addresses of a patron (I used Edna Acosta) - In the 'Primary email' field, enter something like primary@... - In the 'Secondary email' field, enter something like secondary@... - In the 'Email' field of the 'Alternate address' section, enter something like alternate@... 2. Set AutoEmailPrimaryAddress to primary email address (home) 3. Place a recall from the patron's OPAC account 4. Check in the recalled item and confirm recall 5. Check the to_address in the message_queue table for CHECKIN, it should be primary@... select to_address, letter_code, time_queued from message_queue where date(time_queued) = curdate(); 6. Delete the messages from the message_queue. delete from message_queue where to_address like 'primary%'; 7. Change AutoEmailPrimaryAddress to secondary email address (work) 8. From the patron's recalls in the staff interface, click Actions > Revert waiting 9. Redo step 4 and 5. The address in the message_queue table should now be secondary@... 10. Delete the messages from the message_queue. delete from message_queue where to_address like 'secondary%'; 11. Change AutoEmailPrimaryAddress to alternate email address (alternate) 12. Redo step 4 and 5. The address in the message_queue table should now be alternate@... 13. Delete the messages from the message_queue. delete from message_queue where to_address like 'alternate%'; 14. Change AutoEmailPrimaryAddress to cardnumber as 15. Redo step 4 and 5. The address in the message_queue table should now be the patron's cardnumber 16. Delete the messages from the message_queue. delete from message_queue where to_address = '23529001000463'; 17. Change AutoEmailPrimaryAddress to first valid 18. Redo step 4 and 5. The address in the message_queue table should now be primary@... 19. Delete the messages from the message_queue. delete from message_queue where to_address like 'primary%'; 20. Remove the patron's primary email address 21. Redo step 4 and 5. The address in the message_queue table should now be secondary@... 22. Delete the messages from the message_queue. delete from message_queue where to_address like 'secondary%'; 23. Remove the patron's secondary email address 24. Redo steps 4 and 5. The address in the message_queue table should now be alternate@... 25. Delete the messages from the message_queue. delete from message_queue where to_address like 'alternate%'; 26. Remove the patron's alternate email address 27. Redo steps 4 and 5. The address in the message_queue table should now be empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148053|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148130&action=edit Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address This patch updates the enque method in C4::Message to expect a Koha::Patron object in the parameters and then uses that patron object to select the correct email address for notices as defined by AutoEmailPrimaryAddress. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow, nice test plan Caroline.. Thankyou for being so vigorous and thorough :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33191 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33191 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement applies release notes| |the EmailFieldPrimary | |(formerly | |AutoEmailPrimaryAddress) | |system preference choice to | |the CHECKIN, CHECKOUT, | |RENEWAL and various RECALL | |notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- The POD needs an update for the changed parameter Could you provide unit tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148130|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148816&action=edit Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address This patch updates the enque method in C4::Message to expect a Koha::Patron object in the parameters and then uses that patron object to select the correct email address for notices as defined by AutoEmailPrimaryAddress. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148817&action=edit Bug 18398: (follow-up) Update POD & Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Nick :).. POD now updated and Unit tests added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148816|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148838&action=edit Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address This patch updates the enque method in C4::Message to expect a Koha::Patron object in the parameters and then uses that patron object to select the correct email address for notices as defined by AutoEmailPrimaryAddress. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148817|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148839&action=edit Bug 18398: (follow-up) Update POD & Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Backport to 22.11 would probably be good for this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #17 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- doesn't apply to 21.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org