[Bug 30618] New: Important and mandatory select fields not highlighted on additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618 Bug ID: 30618 Summary: Important and mandatory select fields not highlighted on additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If one tries to add an item and mandatory or important select field isn't filled, field isn't highlighted like input fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #1 from Lari Strand <lmstrand@gmail.com> --- As far as I can see, only the select2 elements are not highlighted after the page reloads when mandatory fields have not been filled. I couldn't locate how the "missing" properties to the elements' class are generated (like <input type="text" id="tag_952_subfield_y_371260" name="items.itype" class="input_marceditor items.itype noEnterSubmit missing" maxlength="9999" value="">), but if there was a check on whether the element is a pulldown list/any other type of element not getting highlighted, their styling could be processed separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 188207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188207&action=edit Bug 30618: Highlight missing mandatory select2 elements in item form checks If one tries to add an item and mandatory or important select field isn't filled, field isn't highlighted like input fields. This patch adds correct background color to empty mandatory select2 fields. To test: 1. Add item, but leave mandatory select2 field empty (e.g. home library, itemtype). 2. Attempt to save item. => Note that field isn't highlighted. 3. Apply this patch (restart service if needed). 4. Repeat steps 1. and 2. => Field should now be highlighted. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org Status|Needs Signoff |Failed QA --- Comment #3 from Jason Robb <jrobb@sekls.org> --- I tried testing this in Chrome first and there was no change, the select2 dropdowns marked as "Required" or "Important" don't highlight after trying to add an item without them. Switching to Firefox, the highlighting works on select2 dropdowns marked as "Required", but the dropdowns marked as "Important" still don't highlight. As a testing note, I had to go to Administration > MARC bibliographic frameworks then in the proper framework, navigate to the 952 subfields to test for "Important". Aside from home/holding library, shelving location, collection code, itemtype and the various statuses (lost, not for loan, etc.) use dropdowns. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org