[Bug 16138] New: Restart plack when rotating logfiles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Bug ID: 16138 Summary: Restart plack when rotating logfiles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org On rotating logs, Plack should be restart to avoid permission problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49604&action=edit Bug 16138: Restart plack when rotating logfiles On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to permission issues: Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm : ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97. ...propagated at /usr/share/perl/5.20/base.pm line 106. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68. Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8. Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90. Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation gracefully[1]. I'm not sure how to reproduce it on a dev environment. [1] https://github.com/miyagawa/Starman/issues/55 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49604|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 49736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49736&action=edit Bug 16138: Restart plack when rotating logfiles On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to permission issues: Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm : ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97. ...propagated at /usr/share/perl/5.20/base.pm line 106. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68. Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8. Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90. Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation gracefully[1]. I'm not sure how to reproduce it on a dev environment. [1] https://github.com/miyagawa/Starman/issues/55 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- I could not reproduce the issue, only tested for regression. With patch applied, Koha with Plack still works after forcing logrotate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49736|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 49792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49792&action=edit Bug 16138: Restart plack when rotating logfiles On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to permission issues: Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm : ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97. ...propagated at /usr/share/perl/5.20/base.pm line 106. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68. Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8. Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90. Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation gracefully[1]. I'm not sure how to reproduce it on a dev environment. [1] https://github.com/miyagawa/Starman/issues/55 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple, but effective. I managed to replicated the issues, and his patch fixed them. Cheers Tomas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16974 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 daltonfury42@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daltonfury42@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17717 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org