[Bug 14111] New: Silence warnings t/Auth_with_shibboleth.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Bug ID: 14111 Summary: Silence warnings t/Auth_with_shibboleth.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Remove noise from prove t/Auth_with_shibboleth.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38752&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38832&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5010 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Mark, will take a quick test but looks good from a quick read. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5010 Depends on|5010 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39227&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- A problem here... git bz apply 14111 Bug 14111 - Silence warnings t/Auth_with_shibboleth.t 38832 - Bug 14111 - More t/Auth_with_shibboleth.t silencing 39227 - Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com --- Comment #6 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #5)
A problem here...
git bz apply 14111 Bug 14111 - Silence warnings t/Auth_with_shibboleth.t
38832 - Bug 14111 - More t/Auth_with_shibboleth.t silencing 39227 - Bug 14111: Silence warnings in t/Auth_with_shibboleth.t
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Bernardo: I believe I goofed up there! :-( that mess is quite likely my creation. I'm trying to git-revert. But no success so far. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39227|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39231&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39232&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Okay... Here's the deal. Test the first patch with or without 5010. No issues. It will silence problems. Apply just 5010, and you will see problems. Apply the second patch on top of 5010 and those problems are solved. However, it is still noisy. Apply the first and test it, noise disappears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|0 |1 is obsolete| | --- Comment #10 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39234&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|0 |1 is obsolete| | --- Comment #11 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39235&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |Patch doesn't apply --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Applying: Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5010 | Depends on| |5010 Status|Patch doesn't apply |Signed Off --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #12)
Applying: Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
TEST PLAN ---------- 1) prove t/Auth_with_shibboleth.t -- noise 2) git bz apply 14111 -- interactive first patch only! 3) prove t/Auth_with_shibboleth.t -- no noise 4) git reset --hard origin/master 5) git bz apply 5010 6) prove t/Auth_with_shibboleth.t -- Noise again 7) git bz apply 14111 -- interactive second patch 8) prove t/Auth_with_shibboleth.t -- no noise again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #12)
Applying: Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
See comment #9 and comment #13. I have revised the dependencies again. It's easier to SAY the dependencies than label them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #13)
7) git bz apply 14111
Oops... both, not just second. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39234|0 |1 is obsolete| | Attachment #39235|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39696&action=edit [PASSED QA] Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39697&action=edit [PASSED QA] Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org